-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add hide-unchanged-plan-comments option #3158
feat: add hide-unchanged-plan-comments option #3158
Conversation
49db4f3
to
c370acc
Compare
c370acc
to
e18b361
Compare
Thank you @tufitko ! Please feel free to send more PRs :) |
@tufitko been playing around with the feature today What if we also skipped We'd have to be careful since if there is a change in terraform outputs, it would still say "no changes" but there would technically be a change. |
@nitrocode hmm, I'm not sure how atlantis works with terraform apply... Does it show the plan in applying stage? or we should use the plan from the planning stage? |
@nitrocode oh, also, in the case of plans, we still can see the plan's output in Atlantis UI, but after PR was merged we aren't able to see outputs at all, except comments in PR |
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
Co-authored-by: PePe Amengual <jose.amengual@gmail.com>
what
Add
hide-unchanged-plan-comments
options to removing useless no-changes plans from comments.why
In our repository we have a lot of terragrunt projects. Sometimes we have big pull requests (for example with ~600 projects, usually about 5-6 plans has changes) and It's hard to review.
tests
some tests are added
1 / 6 project with changes
two projects, no changes, nothing to show
without flag output is