Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use int instead of string for bitbucket response. #354

Merged
merged 1 commit into from
Nov 17, 2018

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 16, 2018

Based on https://docs.atlassian.com/bitbucket-server/rest/5.15.0/bitbucket-rest.html the nextPageStart field should be an int.

@codecov
Copy link

codecov bot commented Nov 16, 2018

Codecov Report

Merging #354 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #354   +/-   ##
=======================================
  Coverage   70.67%   70.67%           
=======================================
  Files          61       61           
  Lines        3655     3655           
=======================================
  Hits         2583     2583           
  Misses        893      893           
  Partials      179      179
Impacted Files Coverage Δ
server/events/vcs/bitbucketserver/client.go 38.09% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b63f569...deebb22. Read the comment docs.

Copy link
Contributor

@kipkoan kipkoan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that Bitbucket is returning an int for the nextPageStart field:

curl .../rest/api/1.0/projects/anatf/repos/zoml-platform/pull-requests/1/changes?start=0

...
,"size":25,"isLastPage":false,"start":0,"limit":25,"nextPageStart":25}

@lkysow lkysow merged commit c6dcd65 into master Nov 17, 2018
@lkysow lkysow deleted the bitbucket-nextpagestart branch November 17, 2018 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants