-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove settings for require approval, mergeable, undiverged #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamengual
previously approved these changes
Dec 13, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @lukemassa
/cherry-pick release-0.27 |
X-Guardian
approved these changes
Dec 22, 2023
34a0b01
to
e39e935
Compare
e39e935
to
8f136a9
Compare
8f136a9
to
134f4f3
Compare
/cherry-pick release-0.27 |
Cherry-pick failed with |
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…unatlantis#4047) * Remove settings for require approval, mergeable, undiverged * Fix
ijames-gc
pushed a commit
to gocardless/atlantis
that referenced
this pull request
Feb 13, 2024
…unatlantis#4047) * Remove settings for require approval, mergeable, undiverged * Fix
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Require settings in user_config.go for RequireApproval, RequireMergeable, and RequireUndiverged, and remove the flags RequireApproval and RequireMergeable.
why
Requested by #2992, the options were deprecated by d78b106.
The vast majority of the use cases of these flags were by setting them to
false
in tests which calledNewGlobalCfgFromArgs
. Indeed, the only time they were explicitly set to true was inTestNewGlobalCfgFromArgs
itself.RequireUndiverged was actually not set as an actual flag, despite being set in server/user_config.go, so no flag configuration to be removed then.
This change left deprecationWarnings() a functional no-op. We switched from cobra's "deprecated" to "hidden" in b12d487cb with the creation of this function. Maybe in the future if we want to deprecate a field we can go back to using cobra's "MarkDeprecated()", or we can continue to use this dedicated function? That's probably a question best answered at the time.
tests
There should be no functional changes, since both of these flags were hidden and defaulted to false.
references