chore: Remove settings for require approval, mergeable, undiverged

[lukemassa]

what

Require settings in user_config.go for RequireApproval, RequireMergeable, and RequireUndiverged, and remove the flags RequireApproval and RequireMergeable.

why

Requested by #2992, the options were deprecated by d78b106.

The vast majority of the use cases of these flags were by setting them to false in tests which called NewGlobalCfgFromArgs. Indeed, the only time they were explicitly set to true was in TestNewGlobalCfgFromArgs itself.

RequireUndiverged was actually not set as an actual flag, despite being set in server/user_config.go, so no flag configuration to be removed then.

This change left deprecationWarnings() a functional no-op. We switched from cobra's "deprecated" to "hidden" in b12d487cb with the creation of this function. Maybe in the future if we want to deprecate a field we can go back to using cobra's "MarkDeprecated()", or we can continue to use this dedicated function? That's probably a question best answered at the time.

tests

atlantis % go run main.go server --require-approval 
Error: unknown flag: --require-approval
atlantis % go run main.go server --require-mergeable
Error: unknown flag: --require-mergeable

There should be no functional changes, since both of these flags were hidden and defaulted to false.

references

• closes: Deprecate old flags #2992

[jamengual]

Thanks so much @lukemassa

[jamengual]

/cherry-pick release-0.27

[GenPage]

/cherry-pick release-0.27

[gcp-cherry-pick-bot]

Cherry-pick failed with Merge error 6cad7e6482d1e10410662d86c5c9f339fc094371 into temp-cherry-pick-89bc47-release-0.27