Revamp the Contacts UI in preparation for the DAV migration #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not editable as of now
Show a link to old contacts interface instead
Emails are visible by default, the rest are not
Personal is more fitting in some situations (re emails for example), but that's the way nextcloud is doing this, and is generally closer to what vCard itself specifies.
- fixed routing to not show header toolbar in login screen - support both legacy api with one email addr per contact and new with multiple email addresses per contact - support both numeric and string contact id
…ompatibility to contact.ts
petersalomonsen
requested changes
Mar 21, 2019
There was a problem hiding this comment.
@tadzik Would it be possible for you to rebase this on top of master, and reduce the number of commits to one ( or the number of commits that makes sense to show in the public git history )?
Let me know if you need some tips about how to reduce the number of commits, and remove merge commits etc.
|
This has been squashed into #102, so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.