Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow blank password #1273

Closed
runnnt0 opened this issue Jun 2, 2015 · 2 comments
Closed

Disallow blank password #1273

runnnt0 opened this issue Jun 2, 2015 · 2 comments
Labels
Milestone

Comments

@runnnt0
Copy link

runnnt0 commented Jun 2, 2015

In certain jaas / active directory configurations, it is possible to authenticate against AD without providing a password.

From http://webchat.freenode.net/rundeck ...

[10:41] gscheuler: I have been looking at jaas documentation and it seems "guest login" is a feature that mirrors my symptoms
[10:41] • User logs in with a blank password—the properties login module fails to authenticate the user, and authentication proceeds to the guest login module. The guest login module successfully authenticates the user and returns the guest principal.
[10:42] is there a way to disable this feature - or set a flag that basically disallows blank passwords in the password field?

@gschueler gschueler added the bug label Jul 29, 2015
@gschueler gschueler added this to the 2.5.3 milestone Jul 29, 2015
@gschueler
Copy link
Member

if forceBindingLogin="true" and the directory allows Anonymous binds, then a blank password will work

from: https://docs.oracle.com/javase/jndi/tutorial/ldap/faq/context.html

If you supply an empty string, an empty byte/char array, or null to the Context.SECURITY_CREDENTIALS environment property, then an anonymous bind will occur even if the Context.SECURITY_AUTHENTICATION property was set to "simple". This is because for simple authentication, the LDAP requires the password to be nonempty. If a password is not supplied, then the protocol automatically converts the authentication to "none".

the login module needs to prevent blank password

@ypso
Copy link

ypso commented Jan 14, 2019

bug is come back in rundeck 3 :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants