Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directory Resource Issue using JSON files #1828

Closed
ltamaster opened this issue Apr 26, 2016 · 1 comment
Closed

Directory Resource Issue using JSON files #1828

ltamaster opened this issue Apr 26, 2016 · 1 comment
Assignees
@gschueler
Labels
bug
Milestone
2.6.7

Comments

@ltamaster
Copy link
Contributor

When a directory resources is defined using a JSON files inside, if one of the files has some format problems, It is not possible to see any of the nodes defined in the whole directory.

This is the error reported in the catalina.out.

I am using the rundeck 2.6.4-1 version.


2016-04-26 16:48:12,685 ERROR ProjectNodeSupport - Cannot get nodes from [DirectoryResourceModelSource{directory=/home/vagrant/rundeck/projects/Test/etc/resourcedir}]: null
java.lang.NullPointerException
    at com.dtolabs.rundeck.core.resources.format.json.ResourceJsonFormatParser.safe(ResourceJsonFormatParser.java:179)
    at com.dtolabs.rundeck.core.resources.format.json.ResourceJsonFormatParser.addNode(ResourceJsonFormatParser.java:157)
    at com.dtolabs.rundeck.core.resources.format.json.ResourceJsonFormatParser.convertMappedNodes(ResourceJsonFormatParser.java:147)
    at com.dtolabs.rundeck.core.resources.format.json.ResourceJsonFormatParser.convertNodes(ResourceJsonFormatParser.java:114)
    at com.dtolabs.rundeck.core.resources.format.json.ResourceJsonFormatParser.parseDocument(ResourceJsonFormatParser.java:106)
    at com.dtolabs.rundeck.core.resources.format.json.ResourceJsonFormatParser.parseDocument(ResourceJsonFormatParser.java:96)
    at com.dtolabs.rundeck.core.resources.FileResourceModelSource.loadNodes(FileResourceModelSource.java:335)
    at com.dtolabs.rundeck.core.resources.FileResourceModelSource.getNodes(FileResourceModelSource.java:275)
    at com.dtolabs.rundeck.core.resources.FileResourceModelSource.getNodes(FileResourceModelSource.java:258)
    at com.dtolabs.rundeck.core.resources.DirectoryResourceModelSource.loadNodeSets(DirectoryResourceModelSource.java:129)
    at com.dtolabs.rundeck.core.resources.DirectoryResourceModelSource.getNodes(DirectoryResourceModelSource.java:121)
    at com.dtolabs.rundeck.core.common.ProjectNodeSupport.getNodeSet(ProjectNodeSupport.java:88)
    at com.dtolabs.rundeck.core.common.IProjectNodes$getNodeSet.call(Unknown Source)
    at rundeck.services.nodes.CachedProjectNodes.reloadNodeSet(CachedProjectNodes.groovy:24)
    at rundeck.services.nodes.CachedProjectNodes.getNodeSet(CachedProjectNodes.groovy:20)
    at com.dtolabs.rundeck.server.projects.RundeckProject.getNodeSet(RundeckProject.java:45)
    at com.dtolabs.rundeck.core.common.IRundeckProject$getNodeSet.call(Unknown Source)
    at rundeck.controllers.FrameworkController.nodesdata(FrameworkController.groovy:314)
    at rundeck.controllers.FrameworkController$nodesdata$2.callCurrent(Unknown Source)
    at rundeck.controllers.FrameworkController.nodesFragmentData(FrameworkController.groovy:549)
    at rundeck.controllers.FrameworkController$nodesFragmentData$1.callCurrent(Unknown Source)
    at rundeck.controllers.FrameworkController.nodesQueryAjax(FrameworkController.groovy:585)
    at rundeck.controllers.FrameworkController.nodesQueryAjax(FrameworkController.groovy)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
    at java.lang.reflect.Method.invoke(Method.java:498)
    at org.codehaus.groovy.grails.web.servlet.mvc.MixedGrailsControllerHelper.invoke(MixedGrailsControllerHelper.java:154)
    at org.codehaus.groovy.grails.web.servlet.mvc.AbstractGrailsControllerHelper.handleAction(AbstractGrailsControllerHelper.java:375)
    at org.codehaus.groovy.grails.web.servlet.mvc.AbstractGrailsControllerHelper.executeAction(AbstractGrailsControllerHelper.java:252)
    at org.codehaus.groovy.grails.web.servlet.mvc.AbstractGrailsControllerHelper.handleURI(AbstractGrailsControllerHelper.java:205)
    at org.codehaus.groovy.grails.web.servlet.mvc.AbstractGrailsControllerHelper.handleURI(AbstractGrailsControllerHelper.java:126)
    at org.codehaus.groovy.grails.web.servlet.mvc.SimpleGrailsController.handleRequest(SimpleGrailsController.java:72)
    at org.springframework.web.servlet.mvc.SimpleControllerHandlerAdapter.handle(SimpleControllerHandlerAdapter.java:50)
    at org.codehaus.groovy.grails.web.servlet.GrailsDispatcherServlet.doDispatch(GrailsDispatcherServlet.java:347)
    at org.springframework.web.servlet.DispatcherServlet.doService(DispatcherServlet.java:870)
    at org.springframework.web.servlet.FrameworkServlet.processRequest(FrameworkServlet.java:961)
    at org.springframework.web.servlet.FrameworkServlet.doGet(FrameworkServlet.java:852)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:620)
    at org.springframework.web.servlet.FrameworkServlet.service(FrameworkServlet.java:837)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:727)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:303)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.apache.tomcat.websocket.server.WsFilter.doFilter(WsFilter.java:52)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at grails.plugin.cache.web.filter.PageFragmentCachingFilter.doFilter(PageFragmentCachingFilter.java:198)
    at grails.plugin.cache.web.filter.AbstractFilter.doFilter(AbstractFilter.java:63)
    at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:344)
    at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:261)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:101)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:101)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:101)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.apache.catalina.core.ApplicationDispatcher.invoke(ApplicationDispatcher.java:748)
    at org.apache.catalina.core.ApplicationDispatcher.processRequest(ApplicationDispatcher.java:486)
    at org.apache.catalina.core.ApplicationDispatcher.doForward(ApplicationDispatcher.java:411)
    at org.apache.catalina.core.ApplicationDispatcher.forward(ApplicationDispatcher.java:338)
    at org.codehaus.groovy.grails.web.mapping.UrlMappingUtils.forwardRequestForUrlMappingInfo(UrlMappingUtils.java:178)
    at org.codehaus.groovy.grails.web.mapping.UrlMappingUtils.forwardRequestForUrlMappingInfo(UrlMappingUtils.java:144)
    at org.codehaus.groovy.grails.web.mapping.UrlMappingUtils.forwardRequestForUrlMappingInfo(UrlMappingUtils.java:135)
    at org.codehaus.groovy.grails.web.mapping.filter.UrlMappingsFilter.doFilterInternal(UrlMappingsFilter.java:216)
    at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.codehaus.groovy.grails.web.servlet.mvc.GrailsWebRequestFilter.doFilterInternal(GrailsWebRequestFilter.java:69)
    at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.codehaus.groovy.grails.web.filters.HiddenHttpMethodFilter.doFilterInternal(HiddenHttpMethodFilter.java:67)
    at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at com.codahale.metrics.servlet.AbstractInstrumentedFilter.doFilter(AbstractInstrumentedFilter.java:97)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.springframework.web.filter.CharacterEncodingFilter.doFilterInternal(CharacterEncodingFilter.java:88)
    at org.springframework.web.filter.OncePerRequestFilter.doFilter(OncePerRequestFilter.java:107)
    at org.springframework.web.filter.DelegatingFilterProxy.invokeDelegate(DelegatingFilterProxy.java:344)
    at org.springframework.web.filter.DelegatingFilterProxy.doFilter(DelegatingFilterProxy.java:261)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:241)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:208)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:220)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:122)
    at org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:610)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:171)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.valves.AccessLogValve.invoke(AccessLogValve.java:950)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:116)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:408)
    at org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1040)
    at org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:607)
    at org.apache.tomcat.util.net.JIoEndpoint$SocketProcessor.run(JIoEndpoint.java:314)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
    at org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
    at java.lang.Thread.run(Thread.java:745)
@gschueler gschueler added the bug label Apr 27, 2016
@gschueler gschueler added this to the 2.6.7 milestone Apr 27, 2016
@gschueler
Copy link
Member

This is a combination of 2 issues:

  1. JSON parser of data with null values will cause an error
  2. Directory source does not properly handle errors caused by one file to constrain the impact

gschueler added a commit to gschueler/rundeck that referenced this issue Apr 27, 2016
@gschueler
for rundeck#1828 directory source should handle throwable from file s…
4ad556d 
…ources
gschueler added a commit to gschueler/rundeck that referenced this issue Apr 27, 2016
@gschueler
for rundeck#1828: fix resourcejson parser: handle null values
4215252
@gschueler gschueler mentioned this issue Apr 27, 2016
Merged
@gschueler gschueler self-assigned this Apr 27, 2016
gschueler added a commit that referenced this issue Apr 27, 2016
@gschueler
Merge pull request #1831 from gschueler/issue/1828
9902ad9 
fix #1828 json and directory source errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gschueler gschueler

Labels
bug
Projects
None yet
Milestone
2.6.7
Development

No branches or pull requests
2 participants
@gschueler @ltamaster