Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #4622. Multi-valued option now works with option values plugins. #4747

Merged
merged 2 commits into from Apr 25, 2019

Conversation

Projects
None yet
2 participants
@sjrd218
Copy link
Contributor

commented Apr 23, 2019

Fixes #4622. Multi-valued option now works with option values plugins.

@gschueler

This comment has been minimized.

Copy link
Member

commented Apr 24, 2019

Using SortedSet to sort the values might change the expected ordering

@sjrd218

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

True, but since the values variable only takes a sorted set I'm not sure there's an option.

@sjrd218 sjrd218 added this to the 3.0.21 milestone Apr 24, 2019

@gschueler gschueler removed this from the 3.0.21 milestone Apr 24, 2019

@sjrd218

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

I moved the values population from the server side to the client side. Values are now rendered in the order they come from the plugin.

@gschueler gschueler added this to the 3.0.22 milestone Apr 25, 2019

@gschueler gschueler merged commit 3907b3d into master Apr 25, 2019

21 checks passed

Mergeable Mergeable Run has been Completed!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
security/snyk - build.gradle (rundeck) No manifest changes detected
security/snyk - core/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/copyfile-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/flow-control-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/git-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/jasypt-encryption-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/job-state-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/localexec-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/orchestrator-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/script-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/source-refresh-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/stub-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - plugins/upvar-plugin/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeck-storage/build.gradle (rundeck) No manifest changes detected
security/snyk - rundeckapp/build.gradle (rundeck) No new issues
Details
security/snyk - rundeckapp/grails-spa/package.json (rundeck) No manifest changes detected
security/snyk - rundeckapp/metricsweb/build.gradle (rundeck) No manifest changes detected

@gschueler gschueler deleted the issue/4622 branch Apr 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.