Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn off autocomplete on password field #5260

Merged
merged 1 commit into from Sep 17, 2019
Merged

Turn off autocomplete on password field #5260

merged 1 commit into from Sep 17, 2019

Commits on Sep 16, 2019

  1. Turn off autocomplete on password field 

    To satisfy Qualys Vulnerability scanning.
Even though it isn't best practice, because best practice is to use password managers to autocomplete the login fields.
However, it won't be honored by the browsers (for the above reason https://developer.mozilla.org/en-US/docs/Web/Security/Securing_your_site/Turning_off_form_autocompletion#The_autocomplete_attribute_and_login_fields), so users won't get affected.
So this change is only good to silence a vulnerability scanner, it doesn't actually close a vulnerability.

Closes rundeck#5205
    @runephilosof
    runephilosof committed Sep 16, 2019
    Copy the full SHA
    192b453 View commit details
    Browse the repository at this point in the history