-
Notifications
You must be signed in to change notification settings - Fork 912
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5938 error when logging in with empty credentials. #5990
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summarizing, i'm not sure if we should manage this at JS level on the login form. I would feel more comfortable letting the springsec subsystem to deal with this case.
rundeckapp/src/main/groovy/rundeck/services/audit/AuditEventsService.groovy
Outdated
Show resolved
Hide resolved
rundeckapp/src/main/groovy/rundeck/services/audit/AuditEventsService.groovy
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Playing with it, the spinner looks quite cool white waiting for login.
I found a small bug. If i supply a wrong password (rendering the "Invalid username and password.") and then supply an empty username, i get two error messages:
I also tested the password auth using curl and could not replicate the original problem, so that part should be ok too.
Fair enough. |
Disallows submitting the login form with an empty username. Login toggles a spinner to replace the login button so multiple form submissions cannot be attempted.
Check authentication.name first in AuditEventsService.
Disallows submitting the login form with an empty username.
Login toggles a spinner to replace the login button so multiple form submissions cannot be attempted.