Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes when to execute a job using "Remote URL options" #6275 #6276

Merged
merged 2 commits into from Jul 16, 2020
Merged

Fixes when to execute a job using "Remote URL options" #6275 #6276

merged 2 commits into from Jul 16, 2020

Conversation

nvalenzuela20
Copy link
Contributor

fixes: #6275

Fix a problem when to execute a job using "Remote URL options" and "Enforcing from allowed values".

solution implemented
Send the "authContext" in the "ExecutionService.addRemoteOptionSelected" method as a parameter because the OptionsUtil.expandUrl method requires the variable usename of the job
and thus don't incorrectly call the OptionsUtil.getHttpSessionInstance () method.

@nvalenzuela20 nvalenzuela20 added this to the 3.3.1 milestone Jul 14, 2020
@nvalenzuela20 nvalenzuela20 self-assigned this Jul 14, 2020
gschueler
gschueler approved these changes Jul 15, 2020
View reviewed changes
Copy link
Member

@gschueler gschueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

It seems like OptionsUtil.expandUrl falls back to getting the HTTP session for username... I think that should not be done. An enhancement would be to remove that session code and fix all the calls which use that to pass the username explicitly

@jtobard jtobard merged commit e7531d9 into main Jul 16, 2020
@jtobard jtobard deleted the issue/1115 branch July 16, 2020 12:56
@mergify mergify bot mentioned this pull request Jul 16, 2020
Merged
gschueler added a commit that referenced this pull request Sep 16, 2020
@gschueler
Merge pull request #6279 from rundeck/mergify/bp/maint-3.2.x/pr-6276
be1a4b3 
Fixes when to execute a job using "Remote URL options" #6275 (bp #6276)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschueler gschueler gschueler approved these changes

@jtobard jtobard Awaiting requested review from jtobard

Assignees

@nvalenzuela20 nvalenzuela20

Labels
3.2.x 3.3.x backport-to-3.2
Projects
None yet
Milestone
3.3.1
Development

Successfully merging this pull request may close these issues.

Scheduled jobs not running when using Remote URL options and enforcing from allowed values
3 participants
@nvalenzuela20 @gschueler @jtobard