SCM and Git plugin fixes #6353
Merged
SCM and Git plugin fixes #6353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a job is deleted, then another job added with same scm path, it may fail to be serialized to the git repo correctly because the version check counter is not reset
if multiple job changes occur at once, e.g. api import, then asynch handler was not loading correct job definitions and failing to serialize the jobs for scm removed transaction settings, and pass job
|
Tested on local and is working. We have some SCM API tests, it is possible to include tests for this? (In a future iteration I mean) |
jtobard
approved these changes
Aug 7, 2020
gschueler
added a commit
that referenced
this pull request
Sep 1, 2020
SCM and Git plugin fixes (bp #6353)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
Fix several issues with SCM/git serialization.
Describe the solution you've implemented