Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open execution in new tab on middle-click #6601

Merged
merged 1 commit into from
Nov 20, 2020
Merged

Open execution in new tab on middle-click #6601

merged 1 commit into from
Nov 20, 2020

Conversation

ProTip
Copy link
Contributor

@ProTip ProTip commented Nov 3, 2020

Fixes #6600

Describe the solution you've implemented
Add @click.middle handlers to the activity rows which will open the execution in a new tab.

Add @click.middle.stop to the anchor to prevent the multiple tabs from opening.

@ProTip ProTip added this to the 3.3.7 milestone Nov 3, 2020
@mergify mergify bot added the 3.3.x label Nov 3, 2020
@fdevans fdevans requested a review from jtobard November 18, 2020 17:06
jtobard
jtobard approved these changes Nov 20, 2020
View reviewed changes
Copy link
Contributor

@jtobard jtobard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works as expected

@ProTip ProTip merged commit d88ba57 into main Nov 20, 2020
@ProTip ProTip deleted the issue/6600 branch November 20, 2020 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtobard jtobard jtobard approved these changes

Assignees
No one assigned
Labels
3.3.x
Projects
None yet
Milestone
3.3.7
Development

Successfully merging this pull request may close these issues.

Allow middle-clicking row in activities to open new tab
2 participants
@ProTip @jtobard