Fix an issue with notification plugin and dynamic properties #6662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschueler
reviewed
Dec 9, 2020
rundeckapp/src/test/groovy/rundeck/controllers/ScheduledExecutionControllerSpec.groovy
Outdated
Show resolved
Hide resolved
ltamaster
force-pushed
the
edit-job-not-dynamic-prop
branch
from
2c8e8ad
to
032f9ec
Compare
gschueler
approved these changes
Dec 24, 2020
ProTip
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
bug fix
fix an issue with notification plugin + dynamic properties.
When the dynamic property plugin has an exception (for example a key is not found in the storage), the transaction is rolling back and the references fields from scheduledExecution object are lost, which produces an error in the edit form.
Describe the solution you've implemented
call
listNotificationPluginsDynamicPropertieswith a new sessionDescribe alternatives you've considered
Additional context