SCM: SCM job import action when both import/export are enabled can show incorrect status #7010
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* if git import/export use "preserve" uuid feature, and both are enabled, after git import is performed, jobs can still show modified status, because a random UUID was being saved in job metadata as "srcId". * Removed the behavior that stored random UUID as srcId on job create from export listener * refactor export listener into separate class * add tests for export listener * also alleviates a race condition: both job import and export would create new job metadata entry in the DB in different threads unaware of the other entry.
gschueler
added a commit
that referenced
this pull request
Apr 29, 2021
fix: SCM job import action when both import/export are enabled can show incorrect status (backport #7010)
fdevans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
fixes https://github.com/rundeckpro/rundeckpro/issues/1700
Describe the solution you've implemented