Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rundeckpro-1824 ent logstorage config [RUN-78] #7106

Merged
merged 3 commits into from
Jun 9, 2021
Merged

Fix rundeckpro-1824 ent logstorage config [RUN-78] #7106

merged 3 commits into from
Jun 9, 2021

Conversation

gschueler
Copy link
Member

Is this a bugfix, or an enhancement? Please describe.

Fixes https://github.com/rundeckpro/rundeckpro/issues/1824

  • A groovy plugin containing no definition would be registered but later cause NPE loading the plugin

Describe the solution you've implemented

  • prevent NPE when loading spring bean plugins
  • avoid registering groovy script plugins until after they are constructed

@gschueler gschueler added this to the 3.4.0 milestone Jun 9, 2021
@mergify mergify bot added the 3.4.x label Jun 9, 2021
@sjrd218 sjrd218 self-requested a review June 9, 2021 16:18
sjrd218
sjrd218 approved these changes Jun 9, 2021
View reviewed changes
Copy link
Contributor

@sjrd218 sjrd218 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works without error for me.

@gschueler gschueler merged commit d5387bb into main Jun 9, 2021
@gschueler gschueler deleted the fix/1824-ent-logstorage-config branch June 9, 2021 16:19
@mergify mergify bot mentioned this pull request Jun 9, 2021
Merged
gschueler added a commit that referenced this pull request Jun 9, 2021
@gschueler
Merge pull request #7109 from rundeck/mergify/bp/maint-3.3.x/pr-7106
fd8ea66 
Fix rundeckpro-1824 ent logstorage config [RUN-78] (backport #7106)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjrd218 sjrd218 sjrd218 approved these changes

Assignees
No one assigned
Labels
3.4.x backport-to-3.3
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gschueler @sjrd218