RUN-945: Return basic Rundeck server info without any authorization. #7772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f user has READ access, all other data is included
ehe-pd
reviewed
Jun 15, 2022
rundeckapp/src/test/groovy/rundeck/controllers/ApiControllerSpec.groovy
Outdated
Show resolved
Hide resolved
ehe-pd
reviewed
Jun 15, 2022
| ) | ||
| ] | ||
|
|
||
| if(authorizingSystem.isAuthorized(RundeckAccess.System.READ_OR_OPS_ADMIN)){ |
There was a problem hiding this comment.
What is the difference between RundeckAccess.System.AUTH_READ_OR_OPS_ADMIN and RundeckAccess.System.READ_OR_OPS_ADMIN?
There was a problem hiding this comment.
RundeckAccess.System.AUTH_READ_OR_OPS_ADMIN is a string to name auth actions and RundeckAccess.System.READ_OR_OPS_ADMIN is the auth action
There was a problem hiding this comment.
It seems like a duplication.
When I checked the source code, I found
put(AUTH_READ_OR_OPS_ADMIN, READ_OR_OPS_ADMIN);
which indicates those two things are 1:1 matched.
I think there is an opportunity to improve the code. Let's plan it in another PR.
Thanks.
ehe-pd
reviewed
Jun 15, 2022
ehe-pd
approved these changes
Jun 15, 2022
fdevans
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bugfix, or an enhancement? Please describe.
"Process Automation" menu does not work if the user does not have
readaccessDescribe the solution you've implemented
The
/server/infoendpoint was changed to accept request without any authorization and returns only basic info. All other info is included if the user hasreadaccess