-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Examine items #148
Examine items #148
Conversation
public constructor() { | ||
logger.info('Parsing examine data...'); | ||
this.items = parseData('data/config/examine-item-data.yaml'); | ||
this.npcs = new Map<number, Examine>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there are some examines for "monsters" in osrsbox-db, however the ID numbers do not correspond with 435 cache id numbers. For this reason, I've excluded these from this initial PR. Not sure how we want to approach these.
logger.info('Parsing examine data...'); | ||
this.items = parseData('data/config/examine-item-data.yaml'); | ||
this.npcs = new Map<number, Examine>(); | ||
this.objects = new Map<number, Examine>(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know of any source of examine messages for scenery objects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add the packet sizes inside incoming-packet-sizes.ts
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beautiful, thank you~
This PR only includes messages for items which exists in the 435 cache and also share the same name.