added combat events, added combat defense and attack calculations, etc #327
Conversation
…ded prayer (effect) stubs,
…ions, added prayer (effect) stubs,
|
wot |
|
Fixed the build issue - there was a problem with the merge between forks. |
… calculations, content structure added all prayer sound effects fully implemented think skin
src/plugins/buttons/prayer.plugin.ts
Outdated
| import { loopingEvent } from '@engine/game-server'; | ||
| import { TaskExecutor } from '@engine/world/action'; | ||
| import { widgetButtonIds } from '../skills/smithing/smelting-constants'; | ||
| import { magiconnpcActionHandler, MagicOnNPCActionHook, MagicOnNPCAction } from '../../game-engine/world/action/magic-on-npc.action'; |
There was a problem hiding this comment.
Why is this in here? Is this just a template file for prayer that's been copied over from magic-attack.plugin.ts?
I think file this should be left out of the PR or you should update it to a DRAFT and stay on this branch for further development.
There was a problem hiding this comment.
i need it to capture the prayer button press - don't i?
There was a problem hiding this comment.
Yeh you do but it has imports and references of the original file that don't have to do anything with prayer.
Talking about home teleport button, imports at line 9 etc.
There was a problem hiding this comment.
If it's still WIP, I can change the PR to DRAFT so it doesn't get merged like this, because this can probably break stuff if someone tries to fork the server in this state.
There was a problem hiding this comment.
ok i see what you mean now, ill fix and recommit!
|
Sidenote: I've found this article that I and others forgot to mention to you before you embarked on this journey. It's regarding the combat options
|
| /** | ||
| * Button action pipe definition. | ||
| */ | ||
| export default [ 'magic_on_npc', PrayerActionPipe ] as ActionPipe; |
There was a problem hiding this comment.
This is using the magic_on_npc action type instead of whatever is setup for prayer
No description provided.