-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added combat events, added combat defense and attack calculations, etc #327
Conversation
…ded prayer (effect) stubs,
…ions, added prayer (effect) stubs,
wot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😍
Fixed the build issue - there was a problem with the merge between forks. |
… calculations, content structure added all prayer sound effects fully implemented think skin
src/plugins/buttons/prayer.plugin.ts
Outdated
import { loopingEvent } from '@engine/game-server'; | ||
import { TaskExecutor } from '@engine/world/action'; | ||
import { widgetButtonIds } from '../skills/smithing/smelting-constants'; | ||
import { magiconnpcActionHandler, MagicOnNPCActionHook, MagicOnNPCAction } from '../../game-engine/world/action/magic-on-npc.action'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why is this in here? Is this just a template file for prayer that's been copied over from magic-attack.plugin.ts
?
I think file this should be left out of the PR or you should update it to a DRAFT and stay on this branch for further development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i need it to capture the prayer button press - don't i?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeh you do but it has imports and references of the original file that don't have to do anything with prayer.
Talking about home teleport button, imports at line 9 etc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's still WIP, I can change the PR to DRAFT so it doesn't get merged like this, because this can probably break stuff if someone tries to fork the server in this state.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok i see what you mean now, ill fix and recommit!
Sidenote: I've found this article that I and others forgot to mention to you before you embarked on this journey. It's regarding the combat options
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change, looks like a missed typo, or?...
/** | ||
* Button action pipe definition. | ||
*/ | ||
export default [ 'magic_on_npc', PrayerActionPipe ] as ActionPipe; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is using the magic_on_npc
action type instead of whatever is setup for prayer
No description provided.