Assert that we produce diagnostics in vscode. #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinfagnani
approved these changes
Feb 3, 2022
| const config = vscode.workspace.getConfiguration(); | ||
| config.update("lit-plugin.logging", "verbose", true); | ||
| config.update("lit-plugin.rules.no-missing-element-type-definition", "error", true); | ||
| const doc = await vscode.workspace.openTextDocument(vscode.Uri.file(path.join(__dirname, "../../src/test/fixtures/missing-elem-type.ts"))); |
There was a problem hiding this comment.
break up long line? is there a formatter?
There was a problem hiding this comment.
There is a formatter, but it's set to a hella long line length. Wanted to first land these test changes and check in on PRs, then do a commit to reformat everything.
| return diagnostics; | ||
| } | ||
| // Is there a better way to wait for the ts server to be ready? | ||
| // Maybe we can listen for the event that displays and hides the "initializing TS/JS language features" message? |
There was a problem hiding this comment.
Eyeballing it, there's still a bit of time between that message going away and the diagnostics being available. Hm.
|
(pair programmed with @43081j) |
rictic
force-pushed
the
diagnostic-tests
branch
from
8cc294a
to
2d73ac2
Compare
This was referenced Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.