fix: improve creds helper UX #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
…l helper Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
vsiravar
reviewed
Oct 31, 2023
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
Signed-off-by: Justin Alvarez <alvajus@amazon.com>
vsiravar
approved these changes
Oct 31, 2023
pendo324
pushed a commit
that referenced
this pull request
Nov 1, 2023
🤖 I have created a release *beep* *boop* --- ## [1.0.0](v0.9.0...v1.0.0) (2023-10-31) ### chore * update Release-As version to 1.0.0 (not-squashed) ([2c97323](2c97323)) ### Bug Fixes * ecr credential helper hash check ([#668](#668)) ([4b1b0a2](4b1b0a2)) * ecr creds helper and credential_process ([#510](#510)) ([0525753](0525753)) * improve creds helper UX ([#673](#673)) ([bc238cf](bc238cf)) * run SOCI as a systemd service ([#667](#667)) ([24fd649](24fd649)) * soci being reset on vm stop/start ([#672](#672)) ([9df7d32](9df7d32)) ### Build System or External Dependencies * **deps:** Bump github.com/docker/cli from 24.0.6+incompatible to 24.0.7+incompatible ([#665](#665)) ([43a57ff](43a57ff)) * **deps:** Bump github.com/docker/docker from 24.0.6+incompatible to 24.0.7+incompatible ([#666](#666)) ([4e06d28](4e06d28)) * **deps:** Bump github.com/lima-vm/lima from 0.17.2 to 0.18.0 ([#643](#643)) ([f181b89](f181b89)) * **deps:** Bump github.com/onsi/gomega from 1.27.10 to 1.28.0 ([#583](#583)) ([9d1ad57](9d1ad57)) * **deps:** Bump github.com/runfinch/common-tests from 0.7.6 to 0.7.7 ([#609](#609)) ([e21ae83](e21ae83)) * **deps:** Bump github.com/runfinch/common-tests from 0.7.7 to 0.7.8 ([#617](#617)) ([4d942f5](4d942f5)) * **deps:** Bump github.com/shirou/gopsutil/v3 from 3.23.8 to 3.23.9 ([#588](#588)) ([20385b7](20385b7)) * **deps:** Bump golang.org/x/tools from 0.13.0 to 0.14.0 ([#610](#610)) ([8938cf3](8938cf3)) * **deps:** Bump google.golang.org/grpc from 1.53.0 to 1.56.3 ([#658](#658)) ([321487c](321487c)) * **deps:** Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 ([#652](#652)) ([05f9d53](05f9d53)) * **deps:** Bump submodules and dependencies ([#637](#637)) ([b094751](b094751)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
config.json's state when checking if the cred helper is "installed" or notTesting done:
local testing, e2e tests
I've reviewed the guidance in CONTRIBUTING.md
License Acceptance
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.