Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

processor: fix racy variable #43

Merged
merged 1 commit into from
May 22, 2024
Merged

processor: fix racy variable #43

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions processor.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@ import (
"context"
"errors"
"fmt"
"log/slog"
"sync"

"go.opentelemetry.io/otel"
Expand All @@ -24,7 +23,6 @@ type Processor[T1, T2 any] struct {
parallelism int
tracing bool
metrics bool
count int
}

type Config[T1, T2 any] struct {
Expand Down Expand Up @@ -104,7 +102,6 @@ func (p *Processor[T1, T2]) handle(ctx context.Context) error {
if err != nil {
return fmt.Errorf("handler: %w", err)
}
p.count++
hdlSpan.End()

// If there are no messages, we don't need to send nil to destination
Expand Down Expand Up @@ -162,7 +159,6 @@ func (p *Processor[T1, T2]) Run(ctx context.Context) error {
}
// Stop all the workers on shutdown.
cancel()
slog.Info("shutting down processor", "count", p.count)
// TODO: capture errors thrown during shutdown? if we do this, write local
// err first. it represents first seen
wg.Wait()
Expand Down
Loading