Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ErrorHandle -> ErrorFunc #50

Merged
merged 1 commit into from
Jul 4, 2024
Merged

ErrorHandle -> ErrorFunc #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions x/batcher/batcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,9 @@ type ErrorHandler[T any] interface {
HandleError(context.Context, error, []kawa.Message[T]) error
}

type ErrorHandle[T any] func(context.Context, error, []kawa.Message[T]) error
type ErrorFunc[T any] func(context.Context, error, []kawa.Message[T]) error

func (ef ErrorHandle[T]) HandleError(c context.Context, err error, msgs []kawa.Message[T]) error {
func (ef ErrorFunc[T]) HandleError(c context.Context, err error, msgs []kawa.Message[T]) error {
return ef(c, err, msgs)
}

Expand Down Expand Up @@ -94,11 +94,11 @@ func StopTimeout(d time.Duration) func(*Opts) {
}

func DiscardHandler[T any]() ErrorHandler[T] {
return ErrorHandle[T](func(context.Context, error, []kawa.Message[T]) error { return nil })
return ErrorFunc[T](func(context.Context, error, []kawa.Message[T]) error { return nil })
}

func Raise[T any]() ErrorHandler[T] {
return ErrorHandle[T](func(_ context.Context, err error, _ []kawa.Message[T]) error { return err })
return ErrorFunc[T](func(_ context.Context, err error, _ []kawa.Message[T]) error { return err })
}

// NewDestination instantiates a new batcher.
Expand Down
4 changes: 2 additions & 2 deletions x/batcher/batcher_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ func TestBatcherErrors(t *testing.T) {
time.Sleep(110 * time.Millisecond)
return flushErr
}
var errHandler = ErrorHandle[string](func(c context.Context, err error, msgs []kawa.Message[string]) error {
var errHandler = ErrorFunc[string](func(c context.Context, err error, msgs []kawa.Message[string]) error {
assert.ErrorIs(t, err, flushErr)
return err
})
Expand Down Expand Up @@ -263,7 +263,7 @@ func TestBatcherErrors(t *testing.T) {
time.Sleep(110 * time.Millisecond)
return flushErr
}
var errHandler = ErrorHandle[string](func(c context.Context, err error, msgs []kawa.Message[string]) error {
var errHandler = ErrorFunc[string](func(c context.Context, err error, msgs []kawa.Message[string]) error {
assert.ErrorIs(t, err, flushErr)
return err
})
Expand Down
Loading