This repository has been archived by the owner on Apr 16, 2020. It is now read-only.
Fix bug in running the "transfer" test #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehildenb
reviewed
Jul 2, 2019
dist/runCall.js
Outdated
| @@ -229,8 +396,8 @@ module.exports = function (opts, cb) { | |||
|
|
|||
| function createEthereumConfig() { | |||
| var ethereumConfig = new msg_pb.EthereumConfig(); | |||
| ethereumConfig.setMaxcodesize(new Uint8Array([96, 0])); | |||
| ethereumConfig.setAccountstartnonce(new Uint8Array([0])); | |||
| ethereumConfig.setMaxcodesize(new Uint8Array([127, 255, 255, 255])); | |||
There was a problem hiding this comment.
Where is this number [127, 255, 255, 255] coming from? I see the same number used for functions like setPetersburgblocknumber and setConstantinopleblocknumber. It looks like it's being used as a true` flag or something?
There was a problem hiding this comment.
This line and the next one were modified for debugging purposes and I forgot to revert the changes. The number [127, 255, 255, 255] was chosen to avoid a block number collision (see PR#3).
ehildenb
approved these changes
Jul 3, 2019
anvacaru
added a commit
that referenced
this pull request
Jul 8, 2019
anvacaru
added a commit
that referenced
this pull request
Jul 9, 2019
ehildenb
pushed a commit
that referenced
this pull request
Jul 9, 2019
* added evm-semantics submodule * add Jenkinsfile and Makefile * add jobs for ganache and erc20 repos * fix typo * wip run truffle test * run totalsupply test * fix typos in Jenkins file * add Dockerfile * modified Jenkinsfile wip * tweaks for pipeline #1 * tweaks for pipeline #2 * tweaks for pipeline #3 * tweaks for pipeline #4 * tweaks for pipeline #5 * tweaks for pipeline #6 * tweaks for pipeline #7 * update submodule * Dockerfile: add npm dependency * Jenkinsfile, Dockerfile: correct dockerfile to use * Dockerfile: add node-gyp dep, and nodejs-dev * Dockerfile: add libssl1.0-dev dep * Dockerfile: correct paths for ADDs * Dockerfile: libyaml-cpp-dev => libyaml-dev * Makefile: remove uses of sudo, whitespace formatting * Jenkinsfile, Makefile: formatting, add deps-npm target * Makefile: setup PATH correctly for local npm install * Makefile: use simple expansion for PATH * Makefile: correct quotes * Dockerfile, Jenkinsfile, Makefile: setup npm in Dockerfile * Makefile: make sure submodules are updated before building ganache * Makefile: ensure that BUILD_DIR is set * Dockerfile: simpler expression for npm config * Dockerfile: hardcode path to home directory for NPM_PACKAGES * tweaks for pipeline #8 * tweaks for pipeline #9 * tweaks for pipeline #10 * tweaks for pipeline #11 * fix typo * compiling the contracts in the build stage * remove runtest.js * package.json: remove unused package * Jenkinsfile: redirect output from kevm-vm and ganache-cli to log files * Jenkinsfile: change try-catch block * Jenkinsfile: separate cleanup stage * Jenkinsfile: formatting
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an if statement which prevented the data from
kevm-vmto be correctly processed.Updated the files in the
distfolder.Removed the
try-catchblock and now from every incomingVMQuerythe first four bytes which represent the length of the message are ignored for deserialization.