Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnosis: fixed rules that formerly needed split(), to work without it #207

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

denis-bogdanas
Copy link
Contributor

Now split() is not used by any project.

…t. Now `split()` is not used by any project.
@daejunpark
Copy link
Contributor

what did you change? the only makefile? i don't see why the makefile change fixes the split issue. what am i missing here?

@denis-bogdanas
Copy link
Contributor Author

denis-bogdanas commented Mar 25, 2019

Yes only the makefile. Former checkSignatures-loop-success is now divided into checkSignatures-loop-success-middle and checkSignatures-loop-success-end, to replace the effect of split(). But checkSignatures-loop-success-middle needs the full checkSignatures-loop-success to pass. So I added checkSignatures-loop-success-trusted to the list of specs it needs. That's all. Most changes were done in the previous PR. I introduced checkSignatures-loop-success-middle and checkSignatures-loop-success-end there, deleted split(), but commented these new specs because they were failing or not yet tested.

Here are the other related changes: 743f804

@denis-bogdanas denis-bogdanas merged commit f5b636e into master Mar 25, 2019
@denis-bogdanas denis-bogdanas deleted the PR-former-split branch March 25, 2019 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants