-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zeppelin and Vyper on IMap #99
Conversation
The spec for |
.build/.k.rev
Outdated
@@ -1 +1 @@ | |||
b3c558f7aadff0db612263c18ec167639ce1b243 | |||
1768d7f317dd00bbd149995fe62203df68ba869d |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which text editor are you using? no EOL doesn't look good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
VS Code. I am not sure why there is no EOL
.build/.kevm.rev
Outdated
@@ -1 +1 @@ | |||
5d3bbb6d9dd3a2913201071937cb3f00d66832b0 | |||
765edc205dd122242c31739372d90c1fcc38a9c3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
first, you should use this KEVM version:
https://github.com/kframework/evm-semantics/commits/e2492651b03e8d7b0b0789592ad7bac96a72ef5b
forget about keq
branches from now on. it's the temporary version available when you started this work. now you should use the above KEVM version. please make sure the current spec works with the version. also, if you made any changes to the KEVM for this spec, let me know.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
second, you should not change this global .build directory, which affects all other specs. you should create a new .build directory to which zeppelin and vyper Makefiles refer.
I'm not remotely comfortable with the fact that you are recommending people use a several months old commit of evm that happens to also contain changes that were never upstreamed. This is a huge antipattern that is going to bite us in the foot at some point. At the next planning meeting I would like us to discuss a plan to transition all the verification work to the master branches of k and evm. It can wait until we finish the current deadline if necessary but we should NOT start verifying any new contracts until this is done. |
No description provided.