-
-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User persistent docker-compose files #312
Conversation
This looks very useful thanks for your contribution. Will definitely include this in the next release. |
Will do. Question: do you think it would it be more user-friendly to have this structure:
That way the user can symlink I did add the equivalent feature for app.env, I can include it in the PR. |
eb5634e
to
91ddea3
Compare
Would make sense yes so we can easily extend it to more override features in the future |
91ddea3
to
8b9c05e
Compare
Kudos, SonarCloud Quality Gate passed! |
Done! Please note I didn't build the app - I just tested the script in my running installation. However, I'm able to configure:
|
Tested locally works fine! If you have the time, could you add a section in the wiki explaining how to use this feature? |
Relates to #311
I create a docker-compose in the runtipi folder that mounts my
/cellar
volume:Filebrowser gets the volume:
The web app shows my volume:
Note that my pihole app, whcih does not have a user docker-compose, is unaffected.