Feature/k8s mongodb health #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jon-funk
reviewed
Mar 30, 2023
| Suite Setup Suite Initialization | ||
|
|
||
| *** Tasks *** | ||
| Get Access Token |
There was a problem hiding this comment.
Interesting that you made this its own task instead of in the initialization. Why's that?
|
No specific reason. Didn't try it any other way. Is there a reason it
should be there? Seems like it might be easier to debug if it has its own
task. E.g. if it fails, you have to go through the whole setup logs to sort
that out?
…--
Shea Stewart (he/him)
c:647-972-5191 ***@***.***
Book a meeting https://calendly.com/stewartshea
On Thu, Mar 30, 2023, 12:30 p.m. jon-funk ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In codebundles/mongodb-health-gcp-promql/sli.robot
<#103 (comment)>
:
> @@ -0,0 +1,193 @@
+*** Settings ***
+Metadata Author Shea Stewart
+Documentation Uses promql on the Ops Suite API to determine the health of a MongoDB database instance
+... and pushes the result as an SLI metric. Produces a 1 for a healthy resource, or 0 for an unhealthy resource.
+Force Tags GCP OpsSuite PromQL MongoDB
+Library RW.GCP.OpsSuite
+Library RW.Core
+Library RW.Utils
+Library RW.Prometheus
+Library String
+Library Collections
+Suite Setup Suite Initialization
+
+*** Tasks ***
+Get Access Token
Interesting that you made this its own task instead of in the
initialization. Why's that?
—
Reply to this email directly, view it on GitHub
<#103 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AELXHOFL4LP24J6VKTB5FP3W6WYKJANCNFSM6AAAAAAWMEUTGY>
.
You are receiving this because you authored the thread.Message ID:
<runwhen-contrib/rw-public-codecollection/pull/103/review/1365492561@
github.com>
|
jon-funk
approved these changes
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the composite SLI healthcheck for mongodb with promql (GMP).
Also added a couple of touchups to the kong codebundle, mostly cosmetic.
Also adds min/max to json metric keyword.