-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean gemspec/gemfile and add preliminary PrawnPDF formatter test suite #52
Conversation
- remove support for ancient rubygems version (1.2.0, from 2008) - remove rake gem requirement in the Gemfile, since it's already in the gemfile
03f2703
to
9d39cbf
Compare
@Odaeus so! I've done a bit of work with the gemspec and the test suite. there was no test suite for prawn pdf rendering, so I've started a preliminary test suite. |
Pull Request Test Coverage Report for Build 63
💛 - Coveralls |
The content is salvaged from the previous pdf_formatter_test.rb suite.
9d39cbf
to
8cb1046
Compare
@Odaeus ok, I've removed the PrawnPDF formatter "placeholder" unit tests (the broken ones; there are a few working ones, and the new smoke test with real PDF data), so this PR is ready. I've moved the broken ones into a separate branch; I'll repair them, and create a separate PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice small set or changes.
Improving the gemspec and test coverage
kicking it to run again. in prep of merging |
Thanks for the great change @saveriomiroddi |
Closes #50; closes #23.