Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean gemspec/gemfile and add preliminary PrawnPDF formatter test suite #52

Merged
merged 6 commits into from
Jun 3, 2020

Conversation

64kramsystem
Copy link
Member

@64kramsystem 64kramsystem commented Jan 24, 2018

  • remove support for ancient rubygems version (1.2.0, from 2008)
  • remove rake gem requirement in the Gemfile, since it's already in the gemfile
  • remove the pdf-writer dependency, since the PDF formatter is gone
  • downgrade Prawn version, until the test suite is fully restored
  • add preliminary PrawnPDF formatter test suite

Closes #50; closes #23.

- remove support for ancient rubygems version (1.2.0, from 2008)
- remove rake gem requirement in the Gemfile, since it's already in the gemfile
@64kramsystem 64kramsystem added this to the 1.8.0 milestone Jan 24, 2018
@64kramsystem 64kramsystem self-assigned this Jan 24, 2018
@64kramsystem 64kramsystem removed the request for review from Odaeus January 24, 2018 21:44
@64kramsystem 64kramsystem changed the title Clean gemspec/gemfile Clean gemspec/gemfile (WIP) Jan 24, 2018
@64kramsystem 64kramsystem changed the title Clean gemspec/gemfile (WIP) Clean gemspec/gemfile and add preliminary PrawnPDF formatter test suite Jan 24, 2018
@64kramsystem
Copy link
Member Author

@Odaeus so! I've done a bit of work with the gemspec and the test suite. there was no test suite for prawn pdf rendering, so I've started a preliminary test suite.
The prawn dependency needs to stay unfortunately to the previous, very old, version 0.12.0 😭 I will slowly extend the test suite to have reasonable coverage, then I'll have a look again.

@coveralls
Copy link

coveralls commented Jan 24, 2018

Pull Request Test Coverage Report for Build 63

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 580 unchanged lines in 11 files lost coverage.
  • Overall coverage decreased (-60.4%) to 37.115%

Files with Coverage Reduction New Missed Lines %
lib/ruport.rb 4 38.46%
lib/ruport/formatter/template.rb 8 42.86%
lib/ruport/data/feeder.rb 11 35.29%
lib/ruport/formatter.rb 25 57.14%
lib/ruport/formatter/csv.rb 31 37.25%
lib/ruport/formatter/html.rb 32 34.55%
lib/ruport/data/record.rb 43 39.19%
lib/ruport/formatter/text.rb 54 27.63%
lib/ruport/data/grouping.rb 66 36.94%
lib/ruport/controller.rb 78 47.77%
Totals Coverage Status
Change from base Build 54: -60.4%
Covered Lines: 386
Relevant Lines: 1040

💛 - Coveralls

@64kramsystem
Copy link
Member Author

@Odaeus ok, I've removed the PrawnPDF formatter "placeholder" unit tests (the broken ones; there are a few working ones, and the new smoke test with real PDF data), so this PR is ready.

I've moved the broken ones into a separate branch; I'll repair them, and create a separate PR.

Copy link
Collaborator

@kbrock kbrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice small set or changes.

Improving the gemspec and test coverage

@kbrock
Copy link
Collaborator

kbrock commented Jun 3, 2020

kicking it to run again.

in prep of merging

@kbrock kbrock closed this Jun 3, 2020
@kbrock kbrock reopened this Jun 3, 2020
@kbrock kbrock merged commit d572d65 into ruport:master Jun 3, 2020
@kbrock
Copy link
Collaborator

kbrock commented Jun 3, 2020

Thanks for the great change @saveriomiroddi
Sorry for the delay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup the gemspec Dependency on pdf-writer requires out-of-date hoe/rake
3 participants