Fix typed json encoder conversion from scalar's PV slot to JSON_TYPE_INT #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It did not worked correctly for numbers which can be represented by unsigned type but not by signed type: [2^(8*IVSIZE-1), 2^(8*IVSIZE)-1] SvIV and SvUV macros may modify SvIsUV flag, so after calling SvIV it is needed to check if returned value is signed or unsigned. This patch fixes it and add tests for scalars with corner cases in PV slot. Values out of range of perl integers are converted for JSON_TYPE_INT to either IV_MIN or UV_MAX (signed minimal or unsigned maximal represented value in perl).
|
Looks good, thanks, but I'm still working on the smokers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It did not worked correctly for numbers which can be represented by
unsigned type but not by signed type:
[2^(8*IVSIZE-1), 2^(8*IVSIZE)-1]SvIVandSvUVmacros may modifySvIsUVflag, so after callingSvIVit isneeded to check if returned value is signed or unsigned.
This patch fixes it and add tests for scalars with corner cases in
PVslot.Values out of range of perl integers are converted for
JSON_TYPE_INTtoeither
IV_MINorUV_MAX(signed minimal or unsigned maximal representedvalue in perl).