When 'allow_bignum' is enabled, floats and big integers inside structures are not properly decoded #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rurban
reviewed
Nov 16, 2016
karenetheridge
added a commit
to karenetheridge/Test-JSON-Schema-Acceptance
that referenced
this pull request
Dec 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to decode JSON strings that contain floats inside structures, with 'allow_bignum' enabled, I got warnings about syntax errors in eval.
As far as I understood, the code to create the Math::Big(Int|Float) objects in decode took all the JSON string from the beginning of the number to the end of JSON string (instead of just to the end of the number).
Added a couple of tests to illustrate the issue.
Thank you rurban for this great module!