Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Exception#full_message [Bug #14324] #1161

Merged
merged 1 commit into from Aug 19, 2019
Merged

Conversation

znz
Copy link
Member

@znz znz commented Mar 29, 2018

  • Add Exception.to_tty?
  • Add highlight: and order: to Exception#full_message

2.5.1 にバックポートされた変更なので、2.5.0 のドキュメントには注釈付きで出てくるようにしました。

Exception#full_message のデフォルト値は Exception.to_tty? が true の時は

--- full_message(highlight: true, order: :bottom)  -> String

で、false の時は

--- full_message(highlight: false, order: :top)  -> String

になっていて、どうすればいいのか悩んだのですが、
とりあえず true の方を代表として採用して、
@param の説明の方にデフォルト値の説明を書くようにしてみました。

- Add `Exception.to_tty?`
- Add `highlight:` and `order:` to `Exception#full_message`
@sho-h sho-h merged commit 50772cb into rurema:master Aug 19, 2019
@sho-h
Copy link
Member

sho-h commented Aug 19, 2019

最後の @see が 2.5.0 の endの内側かもと思いましたけど、別途直そうかと思います。

sho-h added a commit to sho-h/doctree that referenced this pull request Aug 19, 2019
sho-h added a commit that referenced this pull request Aug 19, 2019
Move link to Exception.to_tty? from #full_message. (see gh-1161)
@znz znz deleted the Bug#14324 branch September 11, 2019 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants