Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C4&C7 digital input to support more modes #32

Closed
ElDominio opened this issue Feb 16, 2022 · 6 comments
Closed

C4&C7 digital input to support more modes #32

ElDominio opened this issue Feb 16, 2022 · 6 comments
Labels

Comments

@ElDominio
Copy link
Collaborator

Change hardware setup to make C4 a full digital input, able to receive 12v/5v or ground when pullup is enabled.

@mck1117
Copy link
Member

mck1117 commented Feb 16, 2022

Hardware should already be a full digital input, no? Permanently enabled pullup, tolerant of +-24V or so.

@ElDominio
Copy link
Collaborator Author

Some people wire, for example, the positive switch of a nitrous solenoid as a "nitrous engaged" input, so being able to disable the internal pullup is important for usecases like this

@rusefillc
Copy link
Contributor

rev A status: C4 response to GND (at the moment we always have pull-up)

@rusefillc rusefillc changed the title C4 digital input to support more modes C4&C7 digital input to support more modes Feb 18, 2022
@ElDominio
Copy link
Collaborator Author

I'd say C7 is fine being as it is (although the pullup should be selectable, some Chryslers have sensors with built-in pullups), C4 does need more modes

andreika-git added a commit that referenced this issue Feb 18, 2022
@andreika-git
Copy link
Collaborator

Done. Added selectable 5v-pullups or pulldowns for C4 and C7.
image

@andreika-git
Copy link
Collaborator

Warning! LEDs will be inversed if pulldown mode is selected for CAM or 2STEP.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants