failing to export gerbers, failing to fail after failing to export gerbers

[rusefillc]

I've created https://github.com/rusefi/rusefi-hardware/blob/main/.github/workflows/create-board.yaml just to export https://github.com/rusefi/rusefi-hardware/tree/main/breakout-boards/Breakout_154pin_284617-1-Connector for now

• it fails to export see error messages at https://github.com/rusefi/rusefi-hardware/actions/runs/5559778665/jobs/10156227662
• job is green even while it has failed

[rusefillc]

@chuckwagoncomputing andreika-git/hellen-one@447c4a6 and andreika-git/hellen-one@dac4376 but I am getting closer to the limit of my abilities here :)

[rusefillc]

@chuckwagoncomputing I think I've fixed the "fails but does not fail job" part. What am I doing wrong with actual export here?...

[rusefillc]

@chuckwagoncomputing I've made some progress looks like VRML export is failing?

[chuckwagoncomputing]

It's showing an error, but the ExportVRML_File function is reporting success, and it's outputting a VRML file. Is the file not correct?

[chuckwagoncomputing]

When I view the vrml file with https://imagetostl.com/view-vrml-online I get:

We've got some pins hovering over the board:

But it was even worse before: (https://github.com/rusefi/hellen88bmw/blob/1b9764f3ea59727ad798e16315f23c75de213dfd/boards/hellen88bmw-c/board/misc/hellen88bmw-c-3D.wrl.gz)

[chuckwagoncomputing]

I think the problem here is that you're calling ext/hellen-one/bin/gha-commit.sh which doesn't make sense here, and you're calling it from the repo root rather than the directory of the board you're trying to generate gerbers for.
The result is that the files in the gerber/ directory aren't added to the commit.

[rusefillc]

@chuckwagoncomputing great point about working dir for gha-commit.sh 972b37d

[rusefillc]

@chuckwagoncomputing my focus was the assert message I was assuming that it's something bad?

[rusefillc]

looks like we do not care about assert message?