-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
failing to export gerbers, failing to fail after failing to export gerbers #219
Comments
@chuckwagoncomputing andreika-git/hellen-one@447c4a6 and andreika-git/hellen-one@dac4376 but I am getting closer to the limit of my abilities here :) |
@chuckwagoncomputing I think I've fixed the "fails but does not fail job" part. What am I doing wrong with actual export here?... |
@chuckwagoncomputing I've made some progress looks like VRML export is failing? |
It's showing an error, but the ExportVRML_File function is reporting success, and it's outputting a VRML file. Is the file not correct? |
When I view the vrml file with https://imagetostl.com/view-vrml-online I get: |
I think the problem here is that you're calling ext/hellen-one/bin/gha-commit.sh which doesn't make sense here, and you're calling it from the repo root rather than the directory of the board you're trying to generate gerbers for. |
@chuckwagoncomputing great point about working dir for gha-commit.sh 972b37d |
@chuckwagoncomputing my focus was the assert message I was assuming that it's something bad? |
looks like we do not care about assert message? |
I've created https://github.com/rusefi/rusefi-hardware/blob/main/.github/workflows/create-board.yaml just to export https://github.com/rusefi/rusefi-hardware/tree/main/breakout-boards/Breakout_154pin_284617-1-Connector for now
The text was updated successfully, but these errors were encountered: