Launch control bug? "range" thing is confusing #4348

a typo and configurable behaviour without UI
rusefi · Jul 20, 2022 · 4987a0b · 4987a0b
1 parent 9e4187d
commit 4987a0b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/firmware/controllers/algo/launch_control.cpp b/firmware/controllers/algo/launch_control.cpp
@@ -67,7 +67,8 @@ bool LaunchControlBase::isInsideTpsCondition() const {
 		return false;
 	}
 
-	return engineConfiguration->launchTpsTreshold < tps.Value;
+    // todo: should this be 'launchTpsThreshold <= tps.Value' so that nicely calibrated TPS of zero does not prevent launch?
+	return engineConfiguration->launchTpsThreshold < tps.Value;
 }
 
 /**

diff --git a/firmware/integration/rusefi_config.txt b/firmware/integration/rusefi_config.txt
@@ -960,7 +960,7 @@ bit verboseCan2,"Print all","Do not print";Print incoming and outgoing second bu
     int launchBoostDuty;+Duty Cycle for the Boost Solenoid;"%", 1, 0, 0, 100, 0
 	int hardCutRpmRange;Range from Launch RPM to activate Hard Cut;"RPM", 1, 0, 0, 3000, 0
 	int unused962
-	int launchTpsTreshold;;"", 1, 0, 0, 20000, 0
+	int launchTpsThreshold;;"", 1, 0, 0, 20000, 0
 	float launchActivateDelay;;"", 1, 0, 0, 20000, 0
 
 	stft_s stft

diff --git a/firmware/tunerstudio/rusefi.input b/firmware/tunerstudio/rusefi.input
@@ -3835,6 +3835,7 @@ dialog = tcuControls, "Transmission Settings"
 		field = "Launch RPM",            	    		launchRpm,  {launchControlEnabled == 1}
 		;field = "Extra Fuel",           				launchFuelAdded,  {launchControlEnabled == 1}
         ;field = "Boost Solenoid Duty",	                launchBoostDuty,  {launchControlEnabled == 1}
+        field = "TPS Threshold",                        launchTpsThreshold
 		field = "Ignition Retard enable",               enableLaunchRetard,  {launchControlEnabled == 1}
 		field = "Ignition Retard",      				launchTimingRetard,  {launchControlEnabled == 1}
 		field = "Ignition Retard RPM Range",            launchTimingRpmRange,  {launchControlEnabled == 1}

diff --git a/unit_tests/tests/test_launch.cpp b/unit_tests/tests/test_launch.cpp
@@ -7,7 +7,7 @@ TEST(LaunchControl, TpsCondition) {
 
 	LaunchControlBase dut;
 
-	engineConfiguration->launchTpsTreshold = 10;
+	engineConfiguration->launchTpsThreshold = 10;
 
 	// Should return false with failed sensor
 	Sensor::resetMockValue(SensorType::DriverThrottleIntent);
@@ -103,7 +103,7 @@ TEST(LaunchControl, CombinedCondition) {
 	engineConfiguration->launchActivationMode = ALWAYS_ACTIVE_LAUNCH;
 
 	engineConfiguration->launchRpm = 3000;
-	engineConfiguration->launchTpsTreshold = 10;
+	engineConfiguration->launchTpsThreshold = 10;
 	//valid TPS
 	Sensor::setMockValue(SensorType::DriverThrottleIntent, 20.0f);
 
@@ -150,7 +150,7 @@ TEST(LaunchControl, CompleteRun) {
     engineConfiguration->launchSpeedThreshold = 30;
 
 	engineConfiguration->launchRpm = 3000;
-	engineConfiguration->launchTpsTreshold = 10;
+	engineConfiguration->launchTpsThreshold = 10;
 	engineConfiguration->launchControlEnabled = true;
 	//valid TPS
 	Sensor::setMockValue(SensorType::DriverThrottleIntent, 20.0f);