Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java: support compilation by both 8 and 11 #1526

Closed
rusefi opened this issue Jun 20, 2020 · 3 comments
Closed

java: support compilation by both 8 and 11 #1526

rusefi opened this issue Jun 20, 2020 · 3 comments

Comments

@rusefi
Copy link
Collaborator

rusefi commented Jun 20, 2020

My personal preference is to compile using java 8
the only change needed to compile by JDK 11 is

            <!-- uncomment if you want to compile under java 11
            please remove the space between '-' and '-add-exports' it should be double-dash
                        <compilerarg line="- -add-exports java.xml/com.sun.org.apache.xerces.internal.parsers=ALL-UNNAMED"/>
                        <compilerarg line="- -add-exports java.xml/com.sun.org.apache.xml.internal.serialize=ALL-UNNAMED"/>
                        -->

technically it's possible to adjust build.xml to detect what JDK version is used and add those compilerarg conditionally

rusefi pushed a commit that referenced this issue Jun 20, 2020
@rusefillc
Copy link
Contributor

@dron0gus says https://stackoverflow.com/questions/52502189/java-11-package-javax-xml-bind-does-not-exist

could be as easy as adding jaxb into classpath but depends on gradle migration which was a bit postponed

@rusefillc
Copy link
Contributor

rusefillc commented Nov 5, 2021

a proper healthy solution here would be to finish gradle migration (a lot was done already) and then make gradle conditional

see #3014

@rusefillc
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant