New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RAM efficiency of VR crank trigger shapes #2182
Comments
See '#define PWM_PHASE_MAX_COUNT 280' this should go down for REMIX_66_2_2_2 |
This ticket is holding 1+135 TriTach trigger wheel https://rusefi.com/forum/viewtopic.php?f=5&t=1912 |
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912 fixing build?
Status update: no reason to bump PWM_PHASE_MAX_COUNT PROBABLY, at least it's very unclear WHY should we bump PWM_PHASE_MAX_COUNT at this point. Part of the issue is that for some entities we need size PWM_PHASE_MAX_COUNT and for some we might need double that, that's all about crank wheel happening twice per 720 cycle. A number of array bounds checks added into the code. Now the puzzling part: with proper (?) trigger validation something fails with unit tests |
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912
At the moment we cannot add TriTach trigger wheel due to RAM usage.
Trigger definition RAM requirement for large-tooth-number crank wheels should be reduced.
At the moment each tooth is two events (no need for that in case of VR) and the whole wheel is repeated twice (no need for that in case of crank wheels)
The text was updated successfully, but these errors were encountered: