Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAM efficiency of VR crank trigger shapes #2182

Open
rusefillc opened this issue Jan 3, 2021 · 3 comments
Open

RAM efficiency of VR crank trigger shapes #2182

rusefillc opened this issue Jan 3, 2021 · 3 comments

Comments

@rusefillc
Copy link
Contributor

At the moment we cannot add TriTach trigger wheel due to RAM usage.

Trigger definition RAM requirement for large-tooth-number crank wheels should be reduced.

At the moment each tooth is two events (no need for that in case of VR) and the whole wheel is repeated twice (no need for that in case of crank wheels)

@rusefillc
Copy link
Contributor Author

See '#define PWM_PHASE_MAX_COUNT 280' this should go down for REMIX_66_2_2_2

@rusefillc
Copy link
Contributor Author

This ticket is holding 1+135 TriTach trigger wheel https://rusefi.com/forum/viewtopic.php?f=5&t=1912

rusefillc pushed a commit that referenced this issue Jan 5, 2021
rusefillc pushed a commit that referenced this issue Jan 5, 2021
Audi OEM 5-cyl trigger pattern aka "Tri-Tach" https://rusefi.com/forum/viewtopic.php?f=5&t=1912

fixing build?
@rusefillc
Copy link
Contributor Author

Status update:
one bug fixed - assertion was requiring "trigger.length" of events to be below PWM_PHASE_MAX_COUNT but in case of crank wheel "trigger.size" is enough.

no reason to bump PWM_PHASE_MAX_COUNT PROBABLY, at least it's very unclear WHY should we bump PWM_PHASE_MAX_COUNT at this point. Part of the issue is that for some entities we need size PWM_PHASE_MAX_COUNT and for some we might need double that, that's all about crank wheel happening twice per 720 cycle. A number of array bounds checks added into the code.

Now the puzzling part: with proper (?) trigger validation something fails with unit tests
For right now as a work around I have partial shape definition which seems to work more like expected

image

rusefillc pushed a commit that referenced this issue Jan 5, 2021
rusefillc pushed a commit that referenced this issue Jan 5, 2021
rusefillc pushed a commit that referenced this issue Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant