Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrong handling of symmetrical crank wheels NB2 VQ35 Renix #2980

Closed
rusefillc opened this issue Jul 17, 2021 · 5 comments · Fixed by #2982
Closed

wrong handling of symmetrical crank wheels NB2 VQ35 Renix #2980

rusefillc opened this issue Jul 17, 2021 · 5 comments · Fixed by #2982
Labels
bug IMPORTANT

Comments

@rusefillc
Copy link
Contributor

JimStim does not approve of rusEFI trigger shape definition? note errors in coil scheduling

depending on RPM we either have one coil event not even or just totally not present

image

image
@rusefillc
Copy link
Contributor Author

image

@rusefillc
Copy link
Contributor Author

image

@rusefillc
Copy link
Contributor Author

and now self-stim also show uneven sparking, so the problem is NOT trigger definition?!

image

rusefillc pushed a commit that referenced this issue Jul 17, 2021
NB2 trigger shape does not seem to match JimStim #2980
599943c
@rusefillc
Copy link
Contributor Author

rusefillc commented Jul 17, 2021 •
edited

new debug gauge in the "instance RPM" family confirms problem

this log is with external jimstim https://rusefi.com/online/view.php?log=292

image

rusefillc added a commit that referenced this issue Jul 17, 2021
@rusefillc
NB2 trigger shape does not seem to match JimStim #2980
9345e5d 
only first steps of unit test
rusefillc added a commit that referenced this issue Jul 17, 2021
@rusefillc
NB2 trigger shape does not seem to match JimStim #2980
b161a26 
only first steps of unit test
@mck1117
Copy link
Member

mck1117 commented Jul 18, 2021

trigger is correct, prepareEventAngles is broken

@mck1117 mck1117 mentioned this issue Jul 18, 2021
Merged
@rusefillc rusefillc changed the title NB2 trigger shape does not seem to match JimStim wrong handling of symmetrical crank wheels NB1 VQ35 Renix Jul 18, 2021
@rusefillc rusefillc changed the title wrong handling of symmetrical crank wheels NB1 VQ35 Renix wrong handling of symmetrical crank wheels NB2 VQ35 Renix Jul 18, 2021
rusefillc added a commit that referenced this issue Jul 18, 2021
@rusefillc
wrong handling of symmetrical crank wheels NB2 VQ35 Renix #2980
8fab157
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug IMPORTANT
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix prepareEventAngles for symmetrical crank triggers mck1117/rusefi
2 participants
@mck1117 @rusefillc