Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

H7 fast ADC #3301

Open
rusefillc opened this issue Oct 3, 2021 · 11 comments
Open

H7 fast ADC #3301

rusefillc opened this issue Oct 3, 2021 · 11 comments
Assignees

Comments

@rusefillc
Copy link
Contributor

We need fast ADC in H7

@rusefillc
Copy link
Contributor Author

@mck1117 is driving on H7 with only slow ADC to the best of my knowledge

@andreika-git is interested in fast ADC looks like has has custom changes we need to coordinate upstream merge tactics

@andreika-git
Copy link
Collaborator

Related to: #3031

@mck1117
Copy link
Contributor

mck1117 commented Oct 3, 2021

H7 is currently actually using fast ADC exclusively - it just needs a bit of plumbing to make it work.

@rusefillc
Copy link
Contributor Author

@mck1117 we have

#define EFI_USE_FAST_ADC FALSE

is it just a confusing way to say "we use only one kind of ADC speed and it's actually fast but flag name is not great"?

rusefillc pushed a commit that referenced this issue Oct 3, 2021
@rusefillc
Copy link
Contributor Author

Required for #3323

@mck1117 mck1117 mentioned this issue Oct 6, 2021
@andreika-git
Copy link
Collaborator

So do we have a 10kHz sample rate for H7 ADC?

@mck1117
Copy link
Contributor

mck1117 commented Oct 6, 2021

constexpr uint32_t samplingRate = 10000;

@mck1117
Copy link
Contributor

mck1117 commented Oct 6, 2021

H7 uses 10khz hardware triggered ADC, with hardware oversampling. Everything that goes in the buffer is already oversampled, no extra CPU work required.

@rusefillc
Copy link
Contributor Author

@mck1117 do you plan more changes in this area?

@mck1117
Copy link
Contributor

mck1117 commented Oct 11, 2021

I think it's probably OK for now. Normal high speed ADC functions work fine!

@rusefillc
Copy link
Contributor Author

@andreika-git what's the next step for this ticket in your opinion?

rusefillc pushed a commit that referenced this issue Jul 26, 2022
in light of

"// #3301 "H7 is currently actually using fast ADC exclusively - it just needs a bit of plumbing to make it work.""
rusefillc added a commit that referenced this issue May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants