pinout documentation: proteus links not in browser address bar on Proteus black 23

[rusefillc]

all in Chrome:

step 1: open https://rusefi.com/docs/pinouts/microrusefi/
step 2: click on pin 5

result: browser URL has exact URL of pin 5, great https://rusefi.com/docs/pinouts/microrusefi/?connector=main&pin=5

step 3: open https://rusefi.com/docs/pinouts/proteus/
step 4: click on pin 5

result: no change in browser URL
expected result: explicit URL of pin 5

[chuckwagoncomputing]

Proteus does not have the necessary information in the yaml for this feature to work.

[rusefillc]

I am not very smart. I've looked at white35.yaml and mre main.yaml and I do not understand the difference.

also I was assuming that pin: 2 is the unique ID to be used here?

[chuckwagoncomputing]

The important field here is the id field in the info section. I did mention this in #3012, but perhaps I wasn't explicit enough that it was necessary.
Also missing is the name field in the info section, which just adds a label above the connector.

[rusefillc]

Progress, thank you for your patience.

So 7f5b4b7

Let's make those fields mandatory? it looks like current flexibility is just too confusing - at the moment there is no way for a human to guess what fields missing or present cause what effects.

If we simply make those mandatory we would be in a much simpler to comprehend situation

I am happy to adjust all files once generator starts to fail

[rusefillc]

@chuckwagoncomputing we have a problem. Should I revert #3950?

I believe those pins in question cannot really have ID?

  - pin: 23
    function: Crank Pos/Trigger #1 +

  - pin: 24
    function: Crank Neg/Trigger #1 -

  - pin: 25
    function: Cam Pos/Trigger #2 +

is the root cause that "id" should not be primary key but "pin" should?

[chuckwagoncomputing]

Maybe the error message isn't clear enough. The id field goes in the info section; it's not something that each pin has, but rather a single id for the whole connector.
Example:

rusefi/firmware/config/boards/proteus/connectors/black23.yaml

Line 155 in 45c5082

id: black23

Frankenso doesn't even have the info section, and until now the pinout generation has just failed silently. I haven't looked, but I'm sure it's not the only board that doesn't have it.
Maybe we should just print an error message and not fail the whole workflow? i.e. revert the change to misc/jenkins/generate_pinouts/gen_upload_pinouts.sh

[rusefillc]

Oh gotcha

I've just pushed something and poked the action again

[rusefillc]

it's green again!