do not control VVT during cranking

[rusefillc]

during cranking at least on Honda K we get very weird VVT angles, also we do not have oil pressure anyway

I guess we should not bother with VVT PID during cranking?

[mck1117]

random OEM tune has a minimum VVT operation RPM

[blundar]

It is very common in OEM land for there to be a delay between startup and VCT control. I think there is a lot of concern about getting oil pressure to stabilize before diverting oil pressure to do additional things.

…

On Wed, Nov 3, 2021 at 5:46 PM Matthew Kennedy ***@***.***> wrote: random OEM tune has a minimum VVT operation RPM [image: image] <https://user-images.githubusercontent.com/568254/140197466-4bf5cb3d-2ec4-42ca-a32a-2579118002f4.png> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#3443 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPY3CVMJWAFCUBNX23RUBLUKG3TPANCNFSM5HEROOTA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[mck1117]

I think there is a lot of concern about getting oil pressure to stabilize before diverting oil pressure to do additional things.

also, preventing integrator windup during a period of no oil pressure, then oil pressure arrives, and it bonks the cam in to the stop

[mck1117]

so I see a need for two things then:

1. minimum VVT control rpm, if below RPM, reset pid controller and output 0 duty
2. minimum VVT engine run time, if engine not running long enough, reset PID and output 0 duty

[rusefillc]

Yes, but maybe reuse cranking RPM for 1.?

[mck1117]

Yeah, that's probably fine for now unless we come up with a good reason that doesn't work. #2 mostly covers it "engine just started and is at low RPM" anyway.