Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On Proteus Main relay control #3447

Closed
rusefillc opened this issue Nov 2, 2021 · 4 comments
Closed

On Proteus Main relay control #3447

rusefillc opened this issue Nov 2, 2021 · 4 comments

Comments

@rusefillc
Copy link
Contributor

We have EFI_MAIN_RELAY_CONTROL which control is we simply do "1" or vbatt conditional logic for main relay control

most hellens for instance have

DDEFS += -DEFI_MAIN_RELAY_CONTROL=TRUE

it looks like Proteus is NOT using this feature and has less smart MR control

is this a feature or a bug?

@rusefillc
Copy link
Contributor Author

looks to me like at least current Proteus is good for MR control based on VBatt

image

@rusefillc
Copy link
Contributor Author

Same on 0.2

image

rusefillc added a commit that referenced this issue Nov 3, 2021
@mck1117
Copy link
Contributor

mck1117 commented Nov 3, 2021

yes, I think that would be fine to do. I seem to remember the EFI_MAIN_RELAY logic was maybe super complicated, but that's a separate issue.

@rusefillc
Copy link
Contributor Author

@mck1117 you recall correctly - at least at some point EFI_MAIN_RELAY extremely complicated. I believe it was simplified a few months back and one day we shall re-implement the advanced behaviors in a much cleaner way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants