Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bosch Quick Start on B6 Passat is confused about phase #3812

Closed
rusefillc opened this issue Jan 19, 2022 · 9 comments
Closed

Bosch Quick Start on B6 Passat is confused about phase #3812

rusefillc opened this issue Jan 19, 2022 · 9 comments
Labels

Comments

@rusefillc
Copy link
Contributor

See log attached to https://rusefi.com/forum/viewtopic.php?p=44114#p44114

exhibit one - revolution counter increase at 2.235 vvtSyncGapRatio
image

exhibit two - revolution counter increases at 1.556 vvtSyncGapRatio
image

@rusefillc rusefillc added the bug label Jan 19, 2022
@rusefillc
Copy link
Contributor Author

Other triggers tell us to use redundant sync pattern recognition with extra gaps which we do not do here - as is we use single gap length of 1 which means that lucky noise would be treated as sync point

current state:

	int offset = 20;
	s->setTriggerSynchronizationGap3(0, 2, 3);
	s->addEvent360(offset + 0, T_PRIMARY, TV_RISE);

rusefillc pushed a commit that referenced this issue Jan 19, 2022
rusefillc pushed a commit that referenced this issue Jan 19, 2022
OMG :( we were totally not using VVT info of VVT_BOSCH_QUICK_START and VVT_NISSAN_MR and etc etc
@rusefillc
Copy link
Contributor Author

OMG :( we were totally not using VVT info of VVT_BOSCH_QUICK_START and VVT_NISSAN_MR and etc etc

	switch (engineConfiguration->vvtMode[camIndex]) {
	case VVT_FIRST_HALF:
	case VVT_MAP_V_TWIN_ANOTHER:
		return syncAndReport(tc, getCrankDivider(operationMode), 1);
	case VVT_SECOND_HALF:
		return syncAndReport(tc, getCrankDivider(operationMode), 0);
	case VVT_MIATA_NB2:
		/**
		 * NB2 is a symmetrical crank, there are four phases total
		 */
		return syncAndReport(tc, getCrankDivider(operationMode), 0);
	case VVT_NISSAN_VQ:
		return syncAndReport(tc, getCrankDivider(operationMode), 0);
	default:
	case VVT_INACTIVE:
		// do nothing
		return 0;
	}

@racer-coder FYI

@mck1117
Copy link
Contributor

mck1117 commented Jan 19, 2022

@rusefillc can you capture a logic analyzer trace of both the crank and both cam signals for a few cranking attempts (same log is fine, we can cut it up)? Would be a great test case to have like we already have for Miatas and LS.

@rusefillc
Copy link
Contributor Author

@mck1117 yes huge change of logic analyzer trace in the next 48 hours

rusefillc pushed a commit that referenced this issue Jan 19, 2022
running engine proved VVT_BOSCH_QUICK_START to match VVT_SECOND_HALF thus hard-coding phase choice
rusefillc added a commit to rusefi/rusefi_documentation that referenced this issue Jan 19, 2022
@rusefillc
Copy link
Contributor Author

@mck1117 here you are logic analyzer data rusefi/rusefi_documentation@f9c935a

@mck1117
Copy link
Contributor

mck1117 commented Jan 19, 2022

@mck1117 here you are logic analyzer data rusefi/rusefi_documentation@f9c935a

these traces are very very noisy on the vvt channel, what sort of grounding did you use for the logic analyzer?

@rusefillc
Copy link
Contributor Author

Hook to pin soldered to bolt ring

image

@racer-coder
Copy link
Collaborator

TunerStudio logs fast enough that you can capture the cam and hpfp pins. 300 RPM = 1.8 crank degrees/ms. The 3-5ms period would be 5.4-9 degrees per log line, enough to get a rough idea where the cam is relative to hpfp firing. If you had a counter on crank trigger pulses then you could get a rough idea where that is too.

Probably not good enough for writing unit tests, but enough to debug field trigger issues.

@rusefillc
Copy link
Contributor Author

5 degrees of VVT position swing on cranking seems like progress to me :) that's with second gap ratio in pattern definition

image

2022-01-19_21.22.14.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants