Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI Suggestions for Tunerstudio #4722

Closed
ElDominio opened this issue Oct 31, 2022 · 10 comments
Closed

UI Suggestions for Tunerstudio #4722

ElDominio opened this issue Oct 31, 2022 · 10 comments
Assignees

Comments

@ElDominio
Copy link
Collaborator

ElDominio commented Oct 31, 2022

Need separate ticket since need way more details Create a "Tuning" or "Popular" tab with the basics like VE, main ignition, main AFR, accel enrich and idle

done?
Idle% adder for A/C should also be under "Air conditioning"
Fan adders should be under Fans
remove extra idle air and taper until they do something documented
Idle position is under "Sensors - Extra 1" instead of an "Idle" section, even though there's an IDLE PID section with everything but the actual output (for gauges)

I'm going to post a critique of each section individually so my brain doesn't fry

@ElDominio
Copy link
Collaborator Author

ElDominio commented Oct 31, 2022

image

Done Order should be from most important to least, with folders always at the bottom for visual cohesion
Ignition settings


Ignition Advance
Ign CLT correction
Ign IAT correction (important to indicate IGN even though this is the tab because human brains short circuit)


Dwell
Ignition Blend tables (what is an adder bias?)
Per Cylinder Trims

@ElDominio
Copy link
Collaborator Author

ElDominio commented Oct 31, 2022

Put Trigger Gap Override as a part of Advanced Trigger, it is literally an advanced trigger option extracted into #4780
DONE Why is CLT based RPM limit in its own section? imo make it a menu that enables if chosen in the limits category

DONE All the small additional outputs should be clumped together in one or two "Outputs" section, no reason to have two clicks to set each output (more if you count burns every time)

@ElDominio
Copy link
Collaborator Author

image

This one is a bit more involved, but I'd replace "Sensors" with "General I/O" and clump together inputs and puts (seperate with a horizontal lines for inputs and outputs) and keep Advanced for actual advanced functions, like traction control, launch control, flex fuel blending etc

image

Move I/O configuration to that tab, then tables that use that configuration (like VVT) live inside Advanced.

@dron0gus
Copy link
Member

#4723

@ElDominio
Copy link
Collaborator Author

ElDominio commented Nov 3, 2022

Another suggestion: remove deadzone on Closed Loop Ignition timing

@rusefillc
Copy link
Contributor

@ElDominio @dron0gus are we 100% done or less than 100% done here? how do we track what else needs to be changed?

@ElDominio do you have time and motivation to create a new one for remaining stuff? any other approach?

@dron0gus
Copy link
Member

@rusefillc suggestion from only two first messages are done.

@ElDominio
Copy link
Collaborator Author

I have thought a bit more, I think Advanced should eb changed to "Outputs" and take out
-cylinder offsets (group under base engine)
-gear detection (should be under Sensors - Vehicle speed since it's directly dependant on this)
-Lua Analog Inputs (Should be under Sensors, since it's literally a sensor)
--or, yank out all Lua stuff from "Advanced" and put it under a folder in Controller called "LUA", since this is quite related to the controller itself and a very not-begginer-level capability.

-make View the last button or next to last button, the things here are used almost exclusively for debugging. In fact, this sould be a folder under Controller since the views there are all debug functions.

image
o means output, i means input. Alternator and Battery should not be tied together.
Start Button should be renamed to Starter Control.

@rusefillc
Copy link
Contributor

@ElDominio "how do we track what else needs to be changed?" was me trying to say "please stop piling all small separate changes into one ticket it's already impossible to figure out what was done and what still needs to be done"

It would be amazing to separate all things which would be separated while all things relevant together :) "starter control" and "CLT warm-up curve" would be examples of things which seem SEPARATE to me.

rusefillc added a commit that referenced this issue Nov 13, 2022
rusefillc added a commit that referenced this issue Nov 13, 2022
rusefillc added a commit that referenced this issue Nov 13, 2022
@rusefillc
Copy link
Contributor

progress?

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants