Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HW CI is not reliable enough #4772

Open
rusefillc opened this issue Nov 12, 2022 · 17 comments
Open

HW CI is not reliable enough #4772

rusefillc opened this issue Nov 12, 2022 · 17 comments
Assignees

Comments

@rusefillc
Copy link
Contributor

Humans are fucking expensive, we commit a lot. 20 seconds waste of flaky test multiplies.

@rusefillc
Copy link
Contributor Author

@rusefillc
Copy link
Contributor Author

@rusefillc
Copy link
Contributor Author

@rusefillc
Copy link
Contributor Author

@nmschulte this one is a functional defect

not sure if proteus HW_CI setup has external wires like discovery setup has

https://github.com/rusefi/rusefi/actions/runs/3505546092/jobs/5871917337

@mck1117
Copy link
Contributor

mck1117 commented Nov 20, 2022

They both have external wires. The comments in the relevant Java files tell what mods are needed.

@mck1117
Copy link
Contributor

mck1117 commented Nov 20, 2022

Those fails all look like the same thing - comms time out, which may mean that the ECU is locked up. What's the failure rate like?

@rusefillc
Copy link
Contributor Author

i want to say 5%-ish?

@rusefillc
Copy link
Contributor Author

@rusefillc
Copy link
Contributor Author

@rusefillc
Copy link
Contributor Author

@rusefillc
Copy link
Contributor Author

@mck1117
Copy link
Contributor

mck1117 commented Feb 20, 2023

if we increase that 500ms timeout, does it get better?

@rusefillc
Copy link
Contributor Author

@mck1117 what do we increase to 500ms exactly? Everything seems to be at least 500ms already?

image

@mck1117
Copy link
Contributor

mck1117 commented Feb 20, 2023

image

@rusefillc
Copy link
Contributor Author

Sorry did not read it right

@mck1117
Copy link
Contributor

mck1117 commented Feb 20, 2023

but it is strange because just above that it says 5000ms

@rusefillc
Copy link
Contributor Author

@mck1117 i believe different method invocations come with different timeouts

rusefillc pushed a commit that referenced this issue Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants