-
-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HW CI is not reliable enough #4772
Comments
@mck1117 any chance you could help? https://github.com/rusefi/rusefi/actions/runs/3451774157/jobs/5761229627#step:16:1154 |
@nmschulte this one is a functional defect not sure if proteus HW_CI setup has external wires like discovery setup has https://github.com/rusefi/rusefi/actions/runs/3505546092/jobs/5871917337 |
They both have external wires. The comments in the relevant Java files tell what mods are needed. |
Those fails all look like the same thing - comms time out, which may mean that the ECU is locked up. What's the failure rate like? |
i want to say 5%-ish? |
@mck1117 still 5% failure rate https://github.com/rusefi/rusefi/actions/runs/3858743431/jobs/6577597618 |
if we increase that 500ms timeout, does it get better? |
@mck1117 what do we increase to 500ms exactly? Everything seems to be at least 500ms already? |
Sorry did not read it right |
but it is strange because just above that it says 5000ms |
@mck1117 i believe different method invocations come with different timeouts |
Humans are fucking expensive, we commit a lot. 20 seconds waste of flaky test multiplies.
The text was updated successfully, but these errors were encountered: