Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitsubishi 4G93 Trigger issues #4918

Closed
ElDominio opened this issue Dec 29, 2022 · 43 comments
Closed

Mitsubishi 4G93 Trigger issues #4918

ElDominio opened this issue Dec 29, 2022 · 43 comments
Assignees
Labels

Comments

@ElDominio
Copy link
Collaborator

ElDominio commented Dec 29, 2022

What kind of trigger pattern is expected when you choose this?

https://github.com/rusefi/rusefi/wiki/All-Supported-Triggers#mitsubishi

@rusefillc rusefillc changed the title Mitsubishi 4g93 in trigger list but not in wiki? 4g18 matches NA trigger was Mitsubishi 4g93 in trigger list but not in wiki? Dec 29, 2022
@rusefillc
Copy link
Contributor

@ElDominio what do you think about removing that trigger and renaming Miata NA to mention that it's same as Mitsu?

	// todo: this really looks to be same as Miata_NA shall we remove?
	TT_MITSUBISHI = 11,

https://github.com/rusefi/rusefi/wiki/All-Supported-Triggers#mazda-miata-na

@ElDominio
Copy link
Collaborator Author

Maybe call it Miata NA/4G63

@ElDominio
Copy link
Collaborator Author

ElDominio commented Jan 2, 2023

4G18 is not an engine; why was the title changed to that?

Difference between Miata NA/4G63 and 4G93 is that 4G93 is separate Cam/Crank sensors, Miata NA is a CAS unit. I think this is enough reason to keep them separate @rusefillc

Also, I'm having trigger issues on a 4G93 no matter which I choose. I can't get SD log because it's 0kb

Will have LA log soon

@rusefillc
Copy link
Contributor

Google knows 4g13 and for whatever reason we have a reference to 4g18 in the source code I cannot explain that and it's not the most important issue

I see that https://github.com/rusefi/rusefi_documentation/blob/master/Images/triggers/trigger_TT_MITSUBISHI.png image is wrong - circles do not match linear shape

compare to https://github.com/rusefi/rusefi/wiki/All-Supported-Triggers#mazda-miata-na

@ElDominio
Copy link
Collaborator Author

ElDominio commented Jan 2, 2023

https://rusefi.com/online/view.php?log=1135 -> log of what's happening, it runs for a split second and has trigger error. Changing to 4G69 trigger has perfect syncgapratio but RPM = 0

4g93start.zip -> logaic analyzer log

osclog.csv -> ts oscope

EDIT
TT_MITSUBISHI looks like it, but the right side wheel is on crank so it is technically equivalent to Miata NA 4 tooth (since that is at Cam speed)

@ElDominio ElDominio changed the title 4g18 matches NA trigger was Mitsubishi 4g93 in trigger list but not in wiki? Mitsubishi 4G93 Trigger issues Jan 2, 2023
@rusefillc
Copy link
Contributor

@ElDominio

image

does the file open for you? using what version of what app?

@ElDominio
Copy link
Collaborator Author

image

@rusefillc
Copy link
Contributor

yes works with 1.2.40!

@rusefillc
Copy link
Contributor

rusefillc commented Jan 3, 2023

@ElDominio this is now two separate tickets mixed together

  • one issue two similar triggers in software
  • second issue specific vehicle drama

glad to see logic analyzer!

you seem to describe two separate cranking attempts with different settings but only one log?

https://rusefi.com/online/view.php?msq=1352 shows crank as primary input and cam as seconday

image

please clarify if physical wires are flipped (c3-crank goes to cam or crank? c7-cam goes to cam or crank on actual vehicle?) since cam has to be primary input

@ElDominio
Copy link
Collaborator Author

Pretty sure we wired crank to crank+(c3) and cam to c7 and i flipped it in settings

@rusefillc
Copy link
Contributor

rusefillc commented Jan 3, 2023

I am confused. Please confirm what tune URL matches what log URL. Is this a case of tune not matching log?

@ElDominio
Copy link
Collaborator Author

I don't really remember but I do know flipping it didn't work.

The only setting that has at least tried to fire up is Miata NA, both inverted, with Primary set to C7 and Secondary set to C3. But it loses sync quickly and shuts off (which is the behavior seen in the most recent log)

rusefillc pushed a commit to rusefi/rusefi_documentation that referenced this issue Jan 3, 2023
rusefillc added a commit that referenced this issue Jan 3, 2023
adding more info on the trigger images
rusefillc pushed a commit that referenced this issue Jan 3, 2023
rusefillc added a commit that referenced this issue Jan 3, 2023
adding more info on the trigger images
rusefillc pushed a commit to rusefi/rusefi_documentation that referenced this issue Jan 3, 2023
rusefillc pushed a commit to rusefi/rusefi_documentation that referenced this issue Jan 3, 2023
rusefillc pushed a commit to rusefi/rusefi_documentation that referenced this issue Jan 3, 2023
@rusefillc
Copy link
Contributor

trigger documentation now show gaps in light grey for instance "gap 1.90"

image

image

note that one is waiting for only one gap and the other waits for two. note the gap sequence

please post links to four logs
mitsu trigger, cam not inverted
mitsu trigger, cam inverted
miata NA trigger, cam not inverted
miata NA trigger, cam inverted

secondary channel inverted or not would be a separate story, for now let's focus on top cam wheel since that's the one where we see gaps nicely

I guess for secondary inverted or not we will be troubleshooting instant RPM @mck1117 ?

@rusefillc
Copy link
Contributor

PS: look at logs
image

@ElDominio
Copy link
Collaborator Author

using mitsu trigger
2022-12-29_14.04.55.mlg.zip

syncgapratio is content but no RPM

@mck1117
Copy link
Contributor

mck1117 commented Jan 3, 2023

syncgapratio is content but no RPM

syncgapratio is NOT content - look at the sync parameters on the image

image

@ElDominio try these parameters in trigger gap override, if the engine starts, please record SD trigger log of cranking+start+run so we can hardcode better trigger shape

image

@rusefillc
Copy link
Contributor

@mck1117 you seem to be suggesting miata gaps but note the difference between images - mitsu has gaps painted only on falls

void initializeMitsubishi4g18(TriggerWaveform *s) {
	s->initialize(FOUR_STROKE_CAM_SENSOR, SyncEdge::Fall);

vs

void initializeMazdaMiataNaShape(TriggerWaveform *s) {
	s->initialize(FOUR_STROKE_CAM_SENSOR, SyncEdge::Both);

@mck1117
Copy link
Contributor

mck1117 commented Jan 3, 2023

Whatever the gaps are, look at the log - they don't match the number in the image, but WILL sync with the miata numbers (should mitsu also be rising edge??)

@rusefillc
Copy link
Contributor

miata numbers are "BOTH" numbers. miata "BOTH" numbers would not work for mitsu "Fall" would they?

@mck1117
Copy link
Contributor

mck1117 commented Jan 3, 2023

https://rusefi.com/online/view.php?log=1135 shows some gap ratios, are those not the real gap ratios measured on the real engine?

@ElDominio
Copy link
Collaborator Author

That log was made on real engine yes

rusefillc added a commit that referenced this issue Jan 4, 2023
rusefillc pushed a commit that referenced this issue Jan 4, 2023
@ElDominio
Copy link
Collaborator Author

syncgapratio is content but no RPM

syncgapratio is NOT content - look at the sync parameters on the image

image

@ElDominio try these parameters in trigger gap override, if the engine starts, please record SD trigger log of cranking+start+run so we can hardcode better trigger shape

image

Using which settings?

@ElDominio
Copy link
Collaborator Author

ElDominio commented Jan 4, 2023

Engine does not turn on with those settings, it seems to try but the moment it does it loses sync and never runs

Tried with Miata NA with cam inverted and not inverted, and with 4g93 inverted/not inverted

@rusefillc
Copy link
Contributor

I am glad to be right!

Now that you've executed @mck1117's suggestion please consider my request for data as mentioned above

@ElDominio
Copy link
Collaborator Author

logsfor4g93.zip

@mck1117
Copy link
Contributor

mck1117 commented Jan 4, 2023

it seems to try but the moment it does it loses sync and never runs

grab a log of that?

@rusefillc
Copy link
Contributor

Related to #4935

@ElDominio
Copy link
Collaborator Author

it seems to try but the moment it does it loses sync and never runs

grab a log of that?

It's in the "miatanainverted.mlg" but it only shows 204RPM (which it did go over)

@rusefillc
Copy link
Contributor

these two look like winners to me

image

image

note how one is inverted another is not. either we have magic or trigger definitions are inverted.

@ElDominio please confirm that timing light was used to confirm TDC location. I wonder if bad TDC was causing engine to kick

@rusefillc
Copy link
Contributor

image

image

look like loosers?

@ElDominio
Copy link
Collaborator Author

these two look like winners to me

image

image

note how one is inverted another is not. either we have magic or trigger definitions are inverted.

@ElDominio please confirm that timing light was used to confirm TDC location. I wonder if bad TDC was causing engine to kick

Timing only confirmed on miata NA/INVERTED

@mck1117
Copy link
Contributor

mck1117 commented Jan 5, 2023

@rusefillc you can look at triggerToothAngleError to see if teeth are arriving at the correct time

@ElDominio
Copy link
Collaborator Author

@mck1117 @rusefillc anything else I need to get?

@rusefillc
Copy link
Contributor

@ElDominio what's the current problem statement? does the car start/run/happy?

@ElDominio
Copy link
Collaborator Author

start yes
run no
happy definitely no

i have no more requests for logs so idk what else to do

@rusefillc
Copy link
Contributor

plz call?

why does it not run in your opinion? do you have a log where it cranks and starts? why does it not start/run in the logs which look happy in terms of trigger sync?

For your information without tunes I was assuming that ignition/injection was off or something. As is the process is pretty frustrating :( Let's brainstorm how can we make this less spread out in time. Just the logs are not giving at least me the full enough picture, please consider posting to youtube more often. No, pixelated whatsapp videos would not be same :(

@rusefillc
Copy link
Contributor

rusefillc commented Jan 7, 2023

By the way I now see at least two differences between trigger, that's probably enough for them not to be interchangeable

Also let's make a new logic analyzer 4g93 file with spark plugs removed and let me encode new numbers from scratch? also I would make three different variations of the trigger just to get you totally off the rails.

image

image

@ElDominio
Copy link
Collaborator Author

rusefillc added a commit that referenced this issue Jan 7, 2023
@ElDominio
Copy link
Collaborator Author

ElDominio commented Jan 7, 2023

Runs on 4G93 only cam <- woohoo!!!

Issues on 4G93 both fronts

log with crank inverted
4g63 both front only crank invert.zip

log with crank not inverted
4g63 both front no invert.zip

log with crank not inverted, with injectors enabled
4g93bothfront none inverted.zip

@ElDominio
Copy link
Collaborator Author

fun fact:

this only works for revE 4chan, not any previous one

@rusefillc
Copy link
Contributor

https://rusefi.com/online/view.php?log=1143

i see crazy gap ratio I suspect noise. open question is 4chan hardware is problem or not, unfortunately unable to get in touch with @mck1117 on #4656

image

my plan:

@rusefillc
Copy link
Contributor

Let me recap

@mck1117 FYI

@rusefillc
Copy link
Contributor

rusefillc commented Jan 23, 2023

I think we have changed so much it's time for a new ticket with only current status

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants