Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LTS: all vs stm32f407 mess #5016

Closed
rusefillc opened this issue Jan 30, 2023 · 3 comments
Closed

LTS: all vs stm32f407 mess #5016

rusefillc opened this issue Jan 30, 2023 · 3 comments
Assignees
Labels

Comments

@rusefillc
Copy link
Contributor

We have technical debt/historical mess around "default" bundle

  • bundle subfolder is rusefi.snapshot.stm32f407
  • signature says "all" #define TS_SIGNATURE "rusEFI master.2023.01.30.all.2319868418"
  • java has custom code
        RusEfiSignature s = SignatureHelper.parse(signature);
        String bundleName = BundleUtil.readBundleFullName();
        if (bundleName != null && s != null) {
            String signatureWithPrefix;
            if ("all".equals(s.getBundle())) {
                signatureWithPrefix = PREFIX;
            } else {
                signatureWithPrefix = PREFIX + "_" + s.getBundle();
            }

Does discovery auto-update work at the moment? Shall we reduce the amount of technical debt?

@mck1117
Copy link
Contributor

mck1117 commented Jan 31, 2023

maybe it's best for all to go away, since it isn't actually all

@chuckwagoncomputing
Copy link
Member

yep, I'm working on this. I'm aggressively removing stuff and finding out what happens.
https://github.com/rusefi/rusefi/compare/master...chuckwagoncomputing:rusefi:yeet?expand=1

@mck1117
Copy link
Contributor

mck1117 commented Jan 31, 2023

any PR with a branch name like that should be aggressively merged 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants