Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass board dir to scripts instead of board name #5022

Merged
merged 16 commits into from
Feb 6, 2023

Conversation

mck1117
Copy link
Member

@mck1117 mck1117 commented Feb 1, 2023

Allows for building boards that may not necessarily be in the config/boards directory. For example if you want to try rusEFI with some board but not merge yet, you can make a repo, submodule rusEFI, then put your board config files in your repo, then build without needing to modify rusEFI.

  • Simplifies build scripts
  • Simplifies java (java doesn't need hardcoded config/boards any more)
  • Simplifies makefiles (same idea, future change to avoid duplicate lines in many board.h files)

I guess related to #5016

also fix #5033 the right way

@mck1117 mck1117 marked this pull request as ready for review February 1, 2023 21:08
@mck1117 mck1117 marked this pull request as draft February 1, 2023 22:03
@mck1117
Copy link
Member Author

mck1117 commented Feb 1, 2023

let's let #5018 go first

@rusefillc
Copy link
Contributor

@mck1117 we now have #5018

@mck1117 mck1117 marked this pull request as ready for review February 5, 2023 20:47
@mck1117 mck1117 marked this pull request as draft February 5, 2023 21:12
@mck1117
Copy link
Member Author

mck1117 commented Feb 5, 2023

needs #5035

@mck1117 mck1117 marked this pull request as ready for review February 6, 2023 03:47
@rusefillc rusefillc merged commit 4665e67 into rusefi:master Feb 6, 2023
rusefillc pushed a commit that referenced this pull request Jul 20, 2023
rusefillc added a commit that referenced this pull request Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build-firmware (stm32f767_nucleo) build is broken
2 participants