Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

we have weird unconditional coupling with ST_STM32F4_DISCOVERY #5134

Closed
rusefillc opened this issue Feb 26, 2023 · 7 comments
Closed

we have weird unconditional coupling with ST_STM32F4_DISCOVERY #5134

rusefillc opened this issue Feb 26, 2023 · 7 comments

Comments

@rusefillc
Copy link
Contributor

at the moment https://github.com/rusefi/rusefi/blob/master/firmware/hw_layer/ports/stm32/stm32f4/hw_ports.mk says

ALLCSRC += $(CHIBIOS)/os/hal/boards/ST_STM32F4_DISCOVERY/board.c

which is pretty insane

same drama for F7 H7 etc
@rusefillc rusefillc mentioned this issue Feb 26, 2023
Closed
@mck1117
Copy link
Contributor

mck1117 commented Feb 26, 2023

why is that insane?

look at that file, it's completely generic

@rusefillc
Copy link
Contributor Author

rusefi/ChibiOS@c6b4392
rusefi/ChibiOS@fd3770d
rusefi/ChibiOS@284be36

is it in fact completely generic see above? @dron0gus wonders if random AF on random pins is a good thing for andreika-git/hellen-one#262

@mck1117
Copy link
Contributor

mck1117 commented Feb 26, 2023

the *.c is generic, the *.h is not necessarily generic.

@mck1117
Copy link
Contributor

mck1117 commented Feb 26, 2023

Also, the .h edited in those commits is not actually being used - the one being used is at firmware/hw_layer/ports/stm32/stm32f4/board.h

Confirmed this by putting some non-compileable trash in the chibios one and the firmware still builds.

@rusefillc
Copy link
Contributor Author

Ohhh

I shall push a comment at least

@dron0gus
Copy link
Member

Oh, it is even more confusing...

rusefillc added a commit that referenced this issue Feb 26, 2023
@rusefillc
we have weird unconditional coupling with ST_STM32F4_DISCOVERY #5134
e6a4c66
@rusefillc
Copy link
Contributor Author

reverted chibi branch, added comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mck1117 @dron0gus @rusefillc