launch control: Speed threshold depends on launch mode, also zero speed limit handling

[rusefillc]

@Gorfest-n reports
RusEFI master.2023.07.10.alphax-4chan.1914450217

Speed threshold does not work in launch control.
Speed threshold is set to 10 km/h, but after reaching 10 km/h the launch control does not turn off. Red line - turn on the ignition cutoff while reaching the launch rpm.

[rusefillc]

launchSpeedThreshold

[rusefillc]

@Gorfest-n code says

/**
 * Returns True in case Vehicle speed is less then threshold.
 * This condition would only return true based on speed if DisablebySpeed is true
 * The condition logic is written in that way, that if we do not use disable by speed
 * then we have to return true, and trust that we would disable by other condition!
 */ 
bool LaunchControlBase::isInsideSpeedCondition() const {
	int speed = Sensor::getOrZero(SensorType::VehicleSpeed);
	
	return (engineConfiguration->launchSpeedThreshold > speed) || (!(engineConfiguration->launchActivationMode ==  ALWAYS_ACTIVE_LAUNCH));
}

which is why it's nice to have a link to your current tune to know your launchActivationMode