maximumIgnitionTiming does not account timing_offset_cylinder #5894
Labels
Comments
|
Unless something is different on FOME, I'm not sure this is true. Clamping happens before adding the cylinder's offset, which includes both the offset in the firing order and the user-programmed cylinder offset. |
it's definitely different |
rusefillc
changed the title
rusefillc
pushed a commit
that referenced
this issue
Feb 7, 2024
sad work-around to unblock Honda bike
rusefillc
pushed a commit
that referenced
this issue
Feb 7, 2024
sad work-around to unblock Honda bike
rusefillc
added a commit
that referenced
this issue
Feb 29, 2024
rusefillc
added a commit
that referenced
this issue
Feb 29, 2024
only: renaming field so that we do not have two entities with same name and different meaning
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Set timing_offset_cylinder for a funny engine like Harley
problem: ignition is messed up due to default minimumIgnitionTiming and maximumIgnitionTiming no longer making sense
desired: same -10 to 60 IgnitionTiming range is still producing proper results on HD
We have maximumIgnitionTiming and minimumIgnitionTiming safety feature which does not account odd file engine shapes as it probably should
timing_offset_cylinder = "I have a funny engine with cylinders not evenly spaced every 720 / N degrees". Offsets both ignition and fueling.
The text was updated successfully, but these errors were encountered: